Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7921 Kafka offset/history store support #54

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

jcechace
Copy link
Member

@jcechace jcechace commented Jun 4, 2024

@jcechace
Copy link
Member Author

@jpechane This wont make it into 2.7 unfortunately

@ryanvanhuuksloot
Copy link
Contributor

👋 Hello,

I just wanted to hop into this issue (I haven't setup Redhat JIRA yet) and say we'd love to help / test this new feature at Shopify. We've been testing the operator and like the direction - this is a big feature so we're around to support.

@jcechace
Copy link
Member Author

@ryanvanhuuksloot Hey Ryan, it's great hearing that you are testing the operator. I'd be happy hearing any feedback you can provide, or any ideas/request in terms of functionality you might have. Of course PR are definitively welcomed. In any case this will be available soon -- it's nothing problematic, I just haven't gotten around to implementing it for 2.7.

Note that this feature is really more about the cosmetics than anything else -- technically you should be able to just put the configuration under spec.source.config and it would work.

@ryanvanhuuksloot
Copy link
Contributor

ryanvanhuuksloot commented Jul 2, 2024

I'd be happy hearing any feedback you can provide, or any ideas/request in terms of functionality you might have.

I'd love to setup some time to discuss how we are thinking about using the operator. We have some fundamental requirements that we must have to fully migrate but we also see the potential of the operator. I imagine our team can really leverage and contribute to this system if roadmaps align. Would you be open to putting something in the calendar with a few folks from our team (we are primarily EST)?

Of course PR are definitively welcomed.

Amazing - as we continue to test we'll likely be coming back with bugs/fixes.

In any case this will be available soon -- it's nothing problematic, I just haven't gotten around to implementing it for 2.7.
Note that this feature is really more about the cosmetics than anything else -- technically you should be able to just put the configuration under spec.source.config and it would work.

No problem. I didn't realize it was possible. I've had very mixed success with other offset types but I'll try with Kafka and the "less than ideal" config. Or I'll do a custom build with this PR :)

@jcechace
Copy link
Member Author

jcechace commented Jul 2, 2024

Or I'll do a custom build with this PR :)

Once it is resolved. Right now this is just a preparation change which was required. I will try to find the time this week and have this resolved in full.

Would you be open to putting something in the calendar with a few folks from our team (we are primarily EST)?

Anything in the morning (EST) should work.

@jcechace
Copy link
Member Author

jcechace commented Jul 3, 2024

@ryanvanhuuksloot

I've had very mixed success with other offset types but I'll try with Kafka

Perhaps this is something you could elaborate on during our call.

@jcechace jcechace marked this pull request as ready for review July 3, 2024 11:50
Copy link
Contributor

@obabec obabec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my POV, although we have to prepare some tests to verify this.

@jcechace jcechace force-pushed the DBZ-7921 branch 2 times, most recently from 1109043 to ebc1ede Compare July 8, 2024 07:31
@jcechace jcechace merged commit 8773ef3 into debezium:main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants