Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8025: First Pass at adding Observed Generation #67

Merged
merged 1 commit into from
Jul 16, 2024
Merged

DBZ-8025: First Pass at adding Observed Generation #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...perator-api/src/main/java/io/debezium/operator/api/model/status/DebeziumServerStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import java.util.ArrayList;
import java.util.List;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonPropertyDescription;

import io.debezium.operator.docs.annotations.Documented;
Expand All @@ -20,6 +21,10 @@ public class DebeziumServerStatus {
@JsonPropertyDescription("List of status conditions")
private List<Condition> conditions;

@JsonPropertyDescription("Latest observed generation")
@JsonProperty(defaultValue = "0L")
private Long observedGeneration;

public List<Condition> getConditions() {
return conditions;
}
Expand All @@ -34,4 +39,12 @@ public void addToConditions(Condition condition) {
}
conditions.add(condition);
}

public Long getObservedGeneration() {
return observedGeneration;
}

public void setObservedGeneration(Long observedGeneration) {
this.observedGeneration = observedGeneration;
}
}
27 changes: 15 additions & 12 deletions debezium-operator-core/src/main/java/io/debezium/operator/core/DebeziumServerReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

import io.debezium.operator.api.model.DebeziumServer;
import io.debezium.operator.api.model.status.Condition;
Expand Down Expand Up @@ -69,31 +71,32 @@ public UpdateControl<DebeziumServer> reconcile(DebeziumServer debeziumServer, Co
.map(result -> {
if (result.allDependentResourcesReady()) {
Log.infof("Server %s is ready", name);
initializeReadyStatus(debeziumServer);
return UpdateControl.patchStatus(debeziumServer);
initializeReadyStatus(name, debeziumServer);
return UpdateControl.updateStatus(debeziumServer);
}
else {
var delay = Duration.ofSeconds(10);
Log.infof("Server %s not ready yet, rescheduling after %ds", name, delay.toSeconds());
initializeConditions(debeziumServer, new ServerNotReadyCondition(name));
return UpdateControl.patchStatus(debeziumServer).rescheduleAfter(delay);
Log.infof("Server %s not ready yet, rescheduling after %d seconds", name, delay.toSeconds());
initializeNotReadyStatus(name, debeziumServer);
return UpdateControl.updateStatus(debeziumServer).rescheduleAfter(delay);
}
}).orElseThrow();
}

private void initializeReadyStatus(DebeziumServer debeziumServer) {
var name = debeziumServer.getMetadata().getName();
private void initializeReadyStatus(String name, DebeziumServer debeziumServer) {
var ready = new ServerReadyCondition(name);
var running = debeziumServer.isStopped() ? new ServerStoppedCondition(name) : new ServerRunningCondition(name);
initializeConditions(debeziumServer, ready, running);
var status = new DebeziumServerStatus();
status.setConditions(new ArrayList<>(Arrays.asList(ready, running)));
status.setObservedGeneration(debeziumServer.getMetadata().getGeneration());
debeziumServer.setStatus(status);
}

private void initializeConditions(DebeziumServer debeziumServer, Condition... conditions) {
var list = new ArrayList<>(Arrays.asList(conditions));

private void initializeNotReadyStatus(String name, DebeziumServer debeziumServer) {
var condition = new ServerNotReadyCondition(name);
List<Condition> list = Collections.singletonList(condition);
var status = new DebeziumServerStatus();
status.setConditions(list);

debeziumServer.setStatus(status);
}
}
3 changes: 3 additions & 0 deletions k8/debeziumservers.debezium.io-v1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,6 +1819,9 @@ spec:
type: string
type: object
type: array
observedGeneration:
description: Latest observed generation
type: integer
type: object
type: object
served: true
Expand Down