Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8061: Provided Service Account instead of managed #69

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ryanvanhuuksloot
Copy link
Contributor

Adding a potential solution for: https://issues.redhat.com/browse/DBZ-8061

I know this is the way that the operator currently handles PVC, JMX etc. Long term I think it would be better to have ReadOnly Dependents so the reconciliation tree isn't hard to follow.

Tested locally with serviceAccount: default

Name:         <name>-config-view-role-binding
Labels:       <none>
Annotations:  javaoperatorsdk.io/previous: <uuid>
Role:
  Kind:  Role
  Name:  <name>-config-view
Subjects:
  Kind            Name     Namespace
  ----            ----     ---------
  ServiceAccount  default 

Also tested with the traditional managed service account.

@jcechace
Copy link
Member

Seems good. I will explore the possibility of read-only dependents in the future. However in case of SA it might be an overkill (as we are really only concerned about the existence of the SA).

@jcechace jcechace merged commit e33a58b into debezium:main Jul 16, 2024
3 checks passed
@ryanvanhuuksloot ryanvanhuuksloot deleted the DBZ-8061 branch July 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants