DBZ-8352 Update QOSDK #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure related to #78. Wait the nightly image to be built and re-run. |
|
did you rebase? The pipeline should be building the image if I am not mistaken. @obabec do I recall correctly that the system tests will build the image? |
jcechace
reviewed
Nov 27, 2024
debezium-operator-api/src/main/java/io/debezium/operator/api/model/FormatType.java
Outdated
Show resolved
Hide resolved
jcechace
reviewed
Nov 27, 2024
Yeah, you're right. Rebased and tests should pass now. |
jcechace
reviewed
Nov 28, 2024
| @@ -34,6 +34,7 @@ spec: | |||
| type: object | |||
| x-kubernetes-preserve-unknown-fields: true | |||
| type: | |||
| default: json | |||
There was a problem hiding this comment.
can you please rerun the k8update profile? Without using the @Default annotation I don't think v1 generator should actually produce this -- since it should ignore the default from JsonProperty based on the info from fabric8 guys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://issues.redhat.com/browse/DBZ-8452