Fix window title

deccer · Jan 1, 2024 · 4a0db2c · 4a0db2c
1 parent 8d75a8a
commit 4a0db2c
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 7 deletions.
diff --git a/examples/Complex/Complex/appsettings.json b/examples/Complex/Complex/appsettings.json
@@ -21,7 +21,8 @@
     "ResolutionHeight": 1050,
     "ResolutionScale": 1.0,
     "WindowMode": "WindowedBorderless",
-    "IsVsyncEnabled": true
+    "IsVsyncEnabled": true,
+    "Title": "Complex"
   },
   "ContextSettings": {
     "TargetGLVersion": "4.6",

diff --git a/examples/ComputeConvolution/ComputeConvolution/appsettings.json b/examples/ComputeConvolution/ComputeConvolution/appsettings.json
@@ -21,7 +21,8 @@
     "ResolutionHeight": 1080,
     "ResolutionScale": 1.0,
     "WindowMode": "WindowedBorderless",
-    "IsVsyncEnabled": true
+    "IsVsyncEnabled": true,
+    "Title": "ComputeConvolution"
   },
   "ContextSettings": {
     "TargetGLVersion": "4.6",

diff --git a/examples/DeferredRendering/DeferredRendering/appsettings.json b/examples/DeferredRendering/DeferredRendering/appsettings.json
@@ -21,7 +21,8 @@
     "ResolutionHeight": 1080,
     "ResolutionScale": 1.0,
     "WindowMode": "WindowedBorderless",
-    "IsVsyncEnabled": true
+    "IsVsyncEnabled": true,
+    "Title": "DeferredRendering"
   },
   "ContextSettings": {
     "TargetGLVersion": "4.6",

diff --git a/examples/ForwardRendering/ForwardRendering/appsettings.json b/examples/ForwardRendering/ForwardRendering/appsettings.json
@@ -21,7 +21,8 @@
     "ResolutionHeight": 1080,
     "ResolutionScale": 1.0,
     "WindowMode": "WindowedBorderless",
-    "IsVsyncEnabled": true
+    "IsVsyncEnabled": true,
+    "Title": "ForwardRendering"
   },
   "ContextSettings": {
     "TargetGLVersion": "4.6",

diff --git a/examples/HelloWindow/HelloWindow/appsettings.json b/examples/HelloWindow/HelloWindow/appsettings.json
@@ -21,7 +21,8 @@
     "ResolutionHeight": 1050,
     "ResolutionScale": 1.0,
     "WindowMode": "WindowedBorderless",
-    "IsVsyncEnabled": true
+    "IsVsyncEnabled": true,
+    "Title": "HelloWindow"
   },
   "ContextSettings": {
     "TargetGLVersion": "4.6",

diff --git a/src/EngineKit/Application.cs b/src/EngineKit/Application.cs
@@ -234,7 +234,7 @@ protected virtual bool Initialize()
         Glfw.WindowHint(Glfw.WindowOpenGLContextHint.DebugContext, _contextSettings.Value.IsDebugContext);
         Glfw.WindowHint(Glfw.WindowOpenGLContextHint.Profile, Glfw.OpenGLProfile.Core);
 
-        // MESA overrides - useful for windows on intel iGPU
+        // show MESA overrides - useful for windows on intel iGPU
         var environmentVariables = Environment.GetEnvironmentVariables();
         if (environmentVariables.Contains("LIBGL_DEBUG"))
         {
@@ -253,10 +253,11 @@ protected virtual bool Initialize()
             var mesaGlslVersionOverride = environmentVariables["MESA_GLSL_VERSION_OVERRIDE"];
             _logger.Information("{Category}: MESA_GLSL_VERSION_OVERRIDE={MesaGlVersionOverride}", "Environment", mesaGlslVersionOverride);
         }
+
         _windowHandle = Glfw.CreateWindow(
             _applicationContext.WindowSize.X,
             _applicationContext.WindowSize.Y,
-            "OpenSpace",
+            _windowSettings.Value.Title,
             monitorHandle,
             nint.Zero);
         if (_windowHandle == nint.Zero)

diff --git a/src/EngineKit/WindowSettings.cs b/src/EngineKit/WindowSettings.cs
@@ -11,4 +11,6 @@ public class WindowSettings
     public WindowMode WindowMode { get; set; }
 
     public bool IsVsyncEnabled { get; set; }
+
+    public string Title { get; set; } = "EngineKit";
 }