Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade node version to 20.x #678

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: Upgrade node version to 20.x #678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45afaf
chore: Upgrade node version to 20.x
cyaiox May 8, 2024
9537fe4
fix: actions/checkout branch
cyaiox May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/deploy_master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ jobs:
registry-paths: ${{ steps.push-to-quay.outputs.registry-paths }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@master

- name: reconfigure git to use HTTP authentication
run: >
git config --global url."https://github.com/".insteadOf "ssh://[email protected]/"

- name: node.js 18
uses: actions/setup-node@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v4.0.1
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/
cache: 'npm'

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main branch of actions/checkout is main, would you mind changing it?

Suggested change
- uses: actions/checkout@master
- uses: actions/checkout@main


- name: Reconfigure git to use HTTP authentication
run: >
git config --global url."https://github.com/".insteadOf "ssh://[email protected]/"

- name: node.js 18
uses: actions/setup-node@v3
- name: Use Node.js 20.x
uses: actions/setup-node@v4.0.1
with:
node-version: 18.x
node-version: 20.x
registry-url: https://registry.npmjs.org/
cache: 'npm'

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.8-alpine as compiler
FROM node:20.13-alpine as compiler

RUN apk add --no-cache openssh-client \
&& mkdir ~/.ssh && ssh-keyscan github.com > ~/.ssh/known_hosts
Expand Down Expand Up @@ -44,7 +44,7 @@ RUN NODE_OPTIONS="--max-old-space-size=2048" npm run build:server
RUN NODE_OPTIONS="--max-old-space-size=2048" npm run build:front -- --prefix-paths
RUN npm prune --production

FROM node:18.8-alpine
FROM node:20.13-alpine
WORKDIR /app

RUN rm -rf \
Expand Down
Loading