-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx: compress texture before the encoding #3248
base: dev
Are you sure you want to change the base?
Conversation
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Nick!
Code seems fine, but I I think we should add some Profiler metrics to determine the performance impact as well as possible hiccups.
It may not be easy for QA to detect them
I'm particularly worried about compressing textures when the loading screen is absent. Basically, any moment while running through the world
@dalkia agreed |
🔴 Test performed on Windows and Mac:
Camera-Timeout.1.mp4 |
What does this PR change?
Compress textures to save disk space
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md