Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx: compress texture before the encoding #3248

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

NickKhalow
Copy link
Contributor

What does this PR change?

Compress textures to save disk space

How to test the changes?

  1. Launch the explorer
  2. Play happy path

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@NickKhalow NickKhalow requested review from a team as code owners January 29, 2025 13:45
@NickKhalow NickKhalow self-assigned this Jan 29, 2025
Copy link
Collaborator

@dalkia dalkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nick!

Code seems fine, but I I think we should add some Profiler metrics to determine the performance impact as well as possible hiccups.

It may not be easy for QA to detect them

I'm particularly worried about compressing textures when the loading screen is absent. Basically, any moment while running through the world

@NickKhalow
Copy link
Contributor Author

@dalkia agreed

@NickKhalow
Copy link
Contributor Author

image

We should migrate to a background thread

@Ludmilafantaniella
Copy link

Ludmilafantaniella commented Feb 7, 2025

🔴 Test performed on Windows and Mac:

  • Mac: Stuck at 76% loading bar when teleporting from Metadynelabs to Genesis Plaza.
  • Windows: Crash while completing the second quest.
  • Mac: Re-ran test due to previous failure.
  • Windows: Last photos taken in the Gallery don't fully load and also can't be deleted.
  • Mac: Photos in the Gallery don’t load at all.
  • Both platforms: After three teleports and using the camera, encountered a 20% loading bar timeout error.
  • Re-test: After re-entering, the teleport issue didn’t happen on the first attempt but reappeared from the second teleport onward.

mAC.log

Windows.log

Camera-Timeout.1.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants