Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provides motion to SDK avatars shapes when changing position #3297

Merged
merged 34 commits into from
Feb 13, 2025

Conversation

sandrade-dcl
Copy link
Contributor

@sandrade-dcl sandrade-dcl commented Feb 6, 2025

What does this PR change?

Fix #3187

This PR adds motion to the avatar shapes that are created by the SDK so that if these avatars change its position in the scene, they will reproduce the corresponding movement interpolation, lookAt rotation and animation (walk, jog or run) instead of directly teleport the avatar object.

NOTE: If the AvatarShape position and/or rotation is already managed by a Tween, we let Tween system manage it as usual in order to not apply double interpolation and avoid conflicts.

How to test the changes?

  1. Launch the explorer.
  2. Go to any place with avatars generated by the scene (you can go to santihisteria world where I have a test scene prepared to test this PR).
  3. Check that when any avatar changes its position, it is smoothly moved from the point A to the point B (instead of teleporting), reproduces the corresponding movement animation (walk, jog or run) and updates its lookAt rotation to the correct direction.
  4. Now you can go to Angzaar Arts & Shoppes scene (in 9,-76) and check that the NPCs that were floating before, now they are moving correctly with animations.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@sandrade-dcl sandrade-dcl self-assigned this Feb 6, 2025
@sandrade-dcl sandrade-dcl requested review from a team as code owners February 6, 2025 12:09
@sandrade-dcl sandrade-dcl changed the title feat: Provides motion to SDK avatars shapes when changing position feat: Provides motion to SDK avatars shapes when changing position [WIP] Feb 6, 2025
@sandrade-dcl sandrade-dcl requested a review from popuz February 6, 2025 16:01
Copy link
Collaborator

@popuz popuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. Some minor comments

Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! the needed solution is all contained in 1 concise system, looks super maintainable to me.

After Vitaly's suggestions and QA approval it will be ready for merging

@sandrade-dcl sandrade-dcl changed the title feat: Provides motion to SDK avatars shapes when changing position [WIP] feat: Provides motion to SDK avatars shapes when changing position Feb 13, 2025
@sandrade-dcl sandrade-dcl requested a review from popuz February 13, 2025 13:56
@pravusjif pravusjif self-requested a review February 13, 2025 15:21
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✅ Log In/Log Out
  • ✅ Backpack and wearables in world
  • ✅ Emotes in world and in backpack
  • ✅Teleport with map/coordinates/Jump In
  • ✅ Chat and multiplayer
  • ✅ Profile card
  • ✅ Camera
  • ✅ Skybox
  • ✅ Settings

Evidence of all the points verified on this PR :

DAGON.mp4

image

Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments!

@sandrade-dcl sandrade-dcl enabled auto-merge (squash) February 13, 2025 19:29
@sandrade-dcl sandrade-dcl dismissed popuz’s stale review February 13, 2025 21:36

He's currently busy with his shape

@sandrade-dcl sandrade-dcl merged commit 2e733e0 into dev Feb 13, 2025
5 checks passed
@sandrade-dcl sandrade-dcl deleted the fix/add-rotation-and-animations-to-sdk-avatars branch February 13, 2025 21:36
@sandrade-dcl sandrade-dcl removed the request for review from popuz February 13, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angzaar | NPCs glide instead of walk
4 participants