Skip to content

Commit

Permalink
lint and circular deps
Browse files Browse the repository at this point in the history
  • Loading branch information
LiranCohen committed Dec 20, 2023
1 parent 64960d1 commit 56643c9
Show file tree
Hide file tree
Showing 18 changed files with 29 additions and 36 deletions.
11 changes: 1 addition & 10 deletions src/core/message-reply.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
import type { MessagesGetReplyEntry } from '../types/messages-types.js';
import type { QueryResultEntry } from '../types/message-types.js';
import type { RecordsWriteReply } from '../types/records-types.js';

type Status = {
code: number
detail: string
};

export type GenericMessageReply = {
status: Status;
};
import type { GenericMessageReply, QueryResultEntry } from '../types/message-types.js';

export function messageReplyFromError(e: unknown, code: number): GenericMessageReply {

Expand Down
4 changes: 2 additions & 2 deletions src/dwn.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import type { DataStore } from './types/data-store.js';
import type { EventLog } from './types/event-log.js';
import type { GenericMessage } from './types/message-types.js';
import type { MessageStore } from './types/message-store.js';
import type { MethodHandler } from './types/method-handler.js';
import type { Readable } from 'readable-stream';
import type { TenantGate } from './core/tenant-gate.js';
import type { UnionMessageReply } from './core/message-reply.js';
import type { EventsGetMessage, EventsGetReply, EventsQueryMessage, EventsQueryReply } from './types/event-types.js';
import type { GenericMessageReply, UnionMessageReply } from './core/message-reply.js';
import type { GenericMessage, GenericMessageReply } from './types/message-types.js';
import type { MessagesGetMessage, MessagesGetReply } from './types/messages-types.js';
import type { PermissionsGrantMessage, PermissionsRequestMessage, PermissionsRevokeMessage } from './types/permissions-types.js';
import type { ProtocolsConfigureMessage, ProtocolsQueryMessage, ProtocolsQueryReply } from './types/protocols-types.js';
Expand Down
4 changes: 2 additions & 2 deletions src/handlers/events-get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export class EventsGetHandler implements MethodHandler {
const events = await this.eventLog.getEvents(tenant, options);

return {
status: { code: 200, detail: 'OK' },
entries: events
status : { code: 200, detail: 'OK' },
entries : events
};
}
}
4 changes: 2 additions & 2 deletions src/handlers/events-query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export class EventsQueryHandler implements MethodHandler {
const events = await this.eventLog.queryEvents(tenant, logFilters, cursor);

return {
status: { code: 200, detail: 'OK' },
entries: events
status : { code: 200, detail: 'OK' },
entries : events
};
}
}
4 changes: 2 additions & 2 deletions src/handlers/messages-get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ export class MessagesGetHandler implements MethodHandler {
}

return {
status: { code: 200, detail: 'OK' },
entries: messages
status : { code: 200, detail: 'OK' },
entries : messages
};
}
}
2 changes: 1 addition & 1 deletion src/handlers/permissions-grant.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types//event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { KeyValues } from '../types/query-types.js';
import type { MessageStore } from '../types//message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/permissions-request.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types//event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { MessageStore } from '../types//message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
import type { PermissionsRequestMessage } from '../types/permissions-types.js';
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/permissions-revoke.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types/event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { KeyValues } from '../types/query-types.js';
import type { MessageStore } from '../types/message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/protocols-configure.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { DataStore } from '../types/data-store.js';
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types/event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { MessageStore } from '../types//message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
import type { ProtocolsConfigureMessage } from '../types/protocols-types.js';
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/records-delete.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { DataStore } from '../types/data-store.js';
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types/event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { KeyValues } from '../types/query-types.js';
import type { MessageStore } from '../types//message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/records-write.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { DataStore } from '../types/data-store.js';
import type { DidResolver } from '../did/did-resolver.js';
import type { EventLog } from '../types/event-log.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { GenericMessageReply } from '../types/message-types.js';
import type { MessageStore } from '../types//message-store.js';
import type { MethodHandler } from '../types/method-handler.js';
import type { RecordsQueryReplyEntry, RecordsWriteMessage } from '../types/records-types.js';
Expand Down
3 changes: 1 addition & 2 deletions src/types/event-types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { GenericMessageReply } from '../core/message-reply.js';
import type { ProtocolsQueryFilter } from './protocols-types.js';
import type { AuthorizationModel, GenericMessage } from './message-types.js';
import type { AuthorizationModel, GenericMessage, GenericMessageReply } from './message-types.js';
import type { DwnInterfaceName, DwnMethodName } from '../enums/dwn-interface-method.js';
import type { RangeCriterion, RangeFilter } from './query-types.js';

Expand Down
7 changes: 7 additions & 0 deletions src/types/message-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,14 @@ export type Pagination = {
limit?: number;
};

type Status = {
code: number
detail: string
};

export type GenericMessageReply = {
status: Status;
};

export type MessageSort = {
dateCreated?: SortDirection;
Expand Down
5 changes: 2 additions & 3 deletions src/types/messages-types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { GenericMessageReply } from '../core/message-reply.js';
import type { AuthorizationModel, GenericMessage } from './message-types.js';
import type { AuthorizationModel, GenericMessage, GenericMessageReply } from './message-types.js';
import type { DwnInterfaceName, DwnMethodName } from '../enums/dwn-interface-method.js';

export type MessagesGetDescriptor = {
Expand All @@ -23,4 +22,4 @@ export type MessagesGetReplyEntry = {

export type MessagesGetReply = GenericMessageReply & {
entries?: MessagesGetReplyEntry[];
};
};
3 changes: 1 addition & 2 deletions src/types/method-handler.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { GenericMessage } from './message-types.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { Readable } from 'readable-stream';
import type { GenericMessage, GenericMessageReply } from './message-types.js';

/**
* Interface that defines a message handler of a specific method.
Expand Down
3 changes: 1 addition & 2 deletions src/types/protocols-types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { GenericMessageReply } from '../core/message-reply.js';
import type { PublicJwk } from './jose-types.js';
import type { AuthorizationModel, GenericMessage } from './message-types.js';
import type { AuthorizationModel, GenericMessage, GenericMessageReply } from './message-types.js';
import type { DwnInterfaceName, DwnMethodName } from '../enums/dwn-interface-method.js';

export type ProtocolsConfigureDescriptor = {
Expand Down
3 changes: 1 addition & 2 deletions src/types/records-types.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import type { EncryptionAlgorithm } from '../utils/encryption.js';
import type { GeneralJws } from './jws-types.js';
import type { GenericMessageReply } from '../core/message-reply.js';
import type { KeyDerivationScheme } from '../utils/hd-key.js';
import type { PublicJwk } from './jose-types.js';
import type { Readable } from 'readable-stream';
import type { AuthorizationModel, GenericMessage, GenericSignaturePayload, Pagination } from './message-types.js';
import type { AuthorizationModel, GenericMessage, GenericMessageReply, GenericSignaturePayload, Pagination } from './message-types.js';
import type { DwnInterfaceName, DwnMethodName } from '../enums/dwn-interface-method.js';
import type { RangeCriterion, RangeFilter } from './query-types.js';

Expand Down
2 changes: 1 addition & 1 deletion tests/core/message-reply.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { GenericMessageReply } from '../../src/core/message-reply.js';
import type { GenericMessageReply } from '../../src/types/message-types.js';

import { expect } from 'chai';
import { messageReplyFromError } from '../../src/core/message-reply.js';
Expand Down

0 comments on commit 56643c9

Please sign in to comment.