Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#564 - Added delegated grant scoping for RecordsWrite #617

Merged
merged 6 commits into from
Nov 27, 2023
Merged

#564 - Added delegated grant scoping for RecordsWrite #617

merged 6 commits into from
Nov 27, 2023

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented Nov 18, 2023 •
edited
Loading

  1. Added delegated grant scoping for RecordsWrite.
  2. Refactored code so that delegated grant evaluation can reuse the permissions grant evaluation logic.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Nov 18, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@thehenrytsai thehenrytsai marked this pull request as draft November 18, 2023 00:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c01ea2) 98.56% compared to head (4d7f222) 98.57%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   98.56%   98.57%           
=======================================
  Files          68       68           
  Lines        8377     8417   +40     
  Branches     1219     1227    +8     
=======================================
+ Hits         8257     8297   +40     
  Misses        114      114           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehenrytsai
Code refactoring to allow moving of authorization code into MessageIn…
93f2035 
…terface classes without circular dependencies
@thehenrytsai thehenrytsai changed the title [WIP] #564 - Added scoping support for delegated grants [WIP] #564 - Added delegated grant scoping for RecordsWrite Nov 25, 2023
@thehenrytsai thehenrytsai changed the title [WIP] #564 - Added delegated grant scoping for RecordsWrite #564 - Added delegated grant scoping for RecordsWrite Nov 25, 2023
@thehenrytsai thehenrytsai marked this pull request as ready for review November 25, 2023 01:31
LiranCohen
LiranCohen previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only comment I have is regarding the failed delegated test, I think maybe just a comment would be good to denote that Alice would be able to write, since I'm pretty sure some positive tests exist above it somewhere.

tests/scenarios/delegated-grant.spec.ts Show resolved Hide resolved
@thehenrytsai thehenrytsai merged commit 066e74b into main Nov 27, 2023
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/564-scoping branch November 27, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiranCohen LiranCohen LiranCohen approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thehenrytsai @codecov-commenter @LiranCohen