Remove unnecessary conversions to hex format

[frankhinek]

Summary

This PR primarily focuses on performance improvement for the two digital signature algorithms supported by `dwn-sdk-js.

Context

In this Discord thread @shamilovtim noted significant delays while profiling web5-wallet performance.

During the troubleshooting process, a tangentially related issue was discovered that unnecessarily reduces the performance of Ed25519 and secp256k1 sign operations. While updating dwn-sdk-js to the v2.0 versions of @noble/ed5519 and @noble/secp256k1 in PR #396, unnecessary conversions to hex format were added in the sign() method (but not verify()).

The result of this change is that sign() performance degrades rapidly as the data size of the content increases:

With a 100MB data payload, the sign operation in dwn-sdk-js is ⚠️ 40 times slower ⚠️ than it should be.

If we switch the time axis to log scale, you can see that the verify operations both in dwn-sdk-js and @noble/ed25519 track almost identically, since verify does not include the conversion to hex before verification.

Changes

• Remove all occurrences of hex format conversions from both:
  • src/jose/algorithms/signing/ed25519.ts
  • src/utils/secp256k1.ts

After implementing these changes, the performance of the sign operation is nearly identical whether called from the dwn-sdk-js wrapper or directly to the @noble lib and scales linearly as the payload size increases:

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[frankhinek]

Another +1 for migrating dwn-sdk-js to use the @web5/crypto libs 😃

[thehenrytsai]

This is great! Thanks!