fix uint8arrays bug #646
Closed
fix uint8arrays bug #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
LiranCohen
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
shamilovtim
commented
Dec 7, 2023
Comment on lines
61
to
62
| with: | ||
| fail_ci_if_error: true | ||
| continue-on-error: true |
There was a problem hiding this comment.
this was not a reasonable setting for codecov IMO
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 71 71
Lines 9025 9025
Branches 1370 1370
=======================================
Hits 8917 8917
Misses 100 100
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pin uint8arrays to 4.0.8 to resolve achingbrain/uint8arrays#74