generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags for RecordsWrite
and for filters within RecordsQuery
#650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 98.83% 98.84% +0.01%
==========================================
Files 71 71
Lines 9243 9372 +129
Branches 1391 1419 +28
==========================================
+ Hits 9135 9264 +129
Misses 100 100
Partials 8 8 ☔ View full report in Codecov by Sentry. |
RecordsWrite
and for RecordsQuery
RecordsWrite
and for filters within RecordsQuery
64b8925
to
4813120
Compare
…ng for array types
4813120
to
4edb2a7
Compare
Closing in favor if: #706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at adding the functionality for
tags
within records as mentioned here #642.Need to implement size limits for tags, additional tests, and pepper with comments.
Additionally tags are not able to be used as a sort property, right now it returns zero results (as other invalid sort properties would).
Tags are written to records as follows:
// OneOf match tag
Filters as follows:
OneOf match boolean
// OneOf match numeric
// numerical match range
// string match range, can be used for date strings.
Test case to look at: should be able to query by string tags