Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsQuery permissions grant #766

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Jun 20, 2024

Ability to grant permissions to EventsQuery including scoping those permissions down to a specific protocol

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (92b6792) to head (c4cc98a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   98.65%   98.66%   +0.01%     
==========================================
  Files          72       73       +1     
  Lines       10966    11064      +98     
  Branches     1566     1579      +13     
==========================================
+ Hits        10818    10916      +98     
  Misses        142      142              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen force-pushed the lirancohen/events-query-permission-grants branch from 4a827d2 to 13e390a Compare June 21, 2024 17:00
@LiranCohen LiranCohen marked this pull request as ready for review June 21, 2024 19:14
@LiranCohen LiranCohen requested a review from thehenrytsai June 22, 2024 04:26
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 🚀

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 🚀

@LiranCohen LiranCohen merged commit a27a43f into main Jun 25, 2024
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/events-query-permission-grants branch June 25, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants