Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordsGet to RecordsRead #774

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

LiranCohen
Copy link
Member

No description provided.

Base automatically changed from lirancohen/events-to-messages to main June 26, 2024 19:51
@LiranCohen LiranCohen force-pushed the lirancohen/messages-get-to-messages-read branch from 315cecc to 81836d1 Compare June 26, 2024 20:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (4e81d05) to head (58d5318).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files          73       73              
  Lines       11258    11257       -1     
  Branches     1609     1609              
==========================================
- Hits        11111    11110       -1     
  Misses        141      141              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen changed the title [WIP] RecordsGet to RecordsRead RecordsGet to RecordsRead Jun 26, 2024
@LiranCohen LiranCohen marked this pull request as ready for review June 26, 2024 20:15
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

Another satisfying refactoring!

And you are possibly more anal than me on ordering things, and I appreciate it! 🤣

@LiranCohen LiranCohen merged commit c6d8526 into main Jun 27, 2024
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/messages-get-to-messages-read branch June 27, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants