Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MessagesRead response #776

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

LiranCohen
Copy link
Member

  • Added entry to UnionMessageReply that represents response from MessagesRead.
  • Modified MessagesReadReplyEntry to include data as a sibling property to message

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (c6d8526) to head (d4cfba9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          73       73           
  Lines       11257    11263    +6     
  Branches     1609     1609           
=======================================
+ Hits        11110    11116    +6     
  Misses        141      141           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LiranCohen LiranCohen merged commit dfd7bc2 into main Jul 1, 2024
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/move-data-stream-to-entry branch July 1, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants