Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added poller to a resumable task store test to increase reliability #778

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented Jul 2, 2024

For test run using external store implementation (ie. SQL)

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (edf2021) to head (467015c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          73       73           
  Lines       11263    11263           
  Branches     1609     1609           
=======================================
  Hits        11116    11116           
  Misses        141      141           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LiranCohen
LiranCohen previously approved these changes Jul 2, 2024
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@thehenrytsai thehenrytsai merged commit f70442c into main Jul 2, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/resumable-store-test-reliability branch July 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants