Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ENV vars for configuring the BB server #310

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Adds ENV vars for configuring the BB server #310

merged 9 commits into from
Dec 14, 2023

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Dec 7, 2023

fixes #287
supersedes #301

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, let me know if you prefer that I handle the rubocop update

bulletin_board/server/.rubocop.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6e0a171) 69.57% compared to head (a6818dc) 69.57%.

Files Patch % Lines
...letin_board/server/app/graphql/types/query_type.rb 66.66% 3 Missing ⚠️
...r/app/commands/sandbox/generate_load_test_stats.rb 0.00% 1 Missing ⚠️
...oard/server/app/jobs/sandbox/generate_votes_job.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #310   +/-   ##
========================================
  Coverage    69.57%   69.57%           
========================================
  Files           96       96           
  Lines         1630     1630           
========================================
  Hits          1134     1134           
  Misses         496      496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreslucena
Copy link
Member

@microstudi there's a failing spec, can you check it out please?

@microstudi
Copy link
Contributor Author

All done @andreslucena !

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've talked offline, you'll fix the empty line in the next PR, so I'll merge this one

@andreslucena andreslucena merged commit be58cb5 into develop Dec 14, 2023
10 checks passed
@andreslucena andreslucena deleted the env-vars branch December 14, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server settings should be configured by environment variables
3 participants