Merge pull request #13 from deepakmahakale/rspec-3.2.0.rc1

Rspec 3.2.0.rc1

.gitignore

@@ -6,3 +6,9 @@ coverage
 Gemfile.lock
 
 test/
+spec/dummy/tmp
+spec/dummy/log/*.log
+spec/dummy/db/*.sqlite3
+spec/dummy/db/schema.rb
+spec/dummy/db/migrate/*.rb
+spec/dummy/public/*

.travis.yml

@@ -0,0 +1,17 @@
+language: ruby
+rvm:
+  - 2.2.2
+  - 2.3.0
+
+before_script:
+  - cd spec/dummy && bundle exec rake railties:install:migrations
+  - RAILS_ENV=test bundle exec rake db:migrate
+  - cd ../..
+
+script: 'bundle exec rspec'
+
+cache: bundler
+
+notifications:
+  recipients:
+    - [email protected]

README.md

@@ -1,19 +1,24 @@
+[![Build Status](https://travis-ci.org/deepakmahakale/spree_purchase_order.svg?branch=master)](https://travis-ci.org/deepakmahakale/spree_purchase_order)
+
 # Spree Purchase Order
 
 Add Purchase Order payment method in Spree
 
 ## Installation
 
 1. Add this line to your Gemfile:
-
-        gem 'spree_purchase_order'
+  ```ruby
+  gem 'spree_purchase_order'
+  ```
 
 2. Install the gem using Bundler:
-
-        bundle install
+  ```bash
+  bundle install
+  ```
 
 3. Copy & run migrations
+  ```bash
+  bundle exec rails g spree_purchase_order:install
+  ```
 
-        bundle exec rails g spree_purchase_order:install
-
-3. Restart your server
+4. Restart your server

Rakefile

@@ -1,3 +1,4 @@
+#!/usr/bin/env rake
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -10,24 +11,21 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = 'SpreePurchaseOrder'
   rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
+  rdoc.rdoc_files.include('README.md')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
 load 'rails/tasks/engine.rake'
 
-load 'rails/tasks/statistics.rake'
-
 Bundler::GemHelper.install_tasks
 
-require 'rake/testtask'
+Dir[File.join(File.dirname(__FILE__), 'tasks/**/*.rake')].each {|f| load f }
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = false
-end
+require 'rspec/core'
+require 'rspec/core/rake_task'
+
+desc "Run all specs in spec directory (excluding plugin specs)"
+RSpec::Core::RakeTask.new(spec: 'app:db:test:prepare')
 
-task default: :test
+task default: :spec

app/assets/stylesheets/spree/backend/spree_purchase_order.css

@@ -1,3 +1,16 @@
 /*
  *= require spree/backend
  */
+.btn.action-complete {
+  color: #fff;
+  background-color: #7DB942;
+  border-color: #70a63b;
+}
+.btn.action-complete:hover {
+  color: #fff;
+  background-color: #649335;
+  border-color: #52792b;
+}
+.icon.icon-complete:before{
+  content: "\e013";
+}

app/models/spree/payment_decorator.rb

@@ -1,7 +1,7 @@
 Spree::Payment.class_eval do
-  has_one :purchase_order
+  scope :from_purchase_order, -> { where(source_type: 'Spree::PurchaseOrder') }
 
   def po?
-    payment_method.type == 'Spree::PaymentMethod::PurchaseOrder'
+    source_type == 'Spree::PurchaseOrder'
   end
 end

app/models/spree/payment_method/purchase_order.rb

@@ -4,28 +4,12 @@ def payment_source_class
       Spree::PurchaseOrder
     end
 
-    def actions
-      %w(complete void)
-    end
-
-    def can_complete?(payment)
-      %w(checkout pending).include?(payment.state)
-    end
-
-    def can_void?(payment)
-      payment.state != 'void'
-    end
-
     def authorize(*args)
-      ActiveMerchant::Billing::Response.new(true, 'Purchase Order: Success', {}, {})
-    end
-
-    def complete(*)
-      ActiveMerchant::Billing::Response.new(true, 'Purchase Order: Success', {}, {})
+      simulated_successful_billing_response('Purchase Order: Success')
     end
 
     def void(*args)
-      ActiveMerchant::Billing::Response.new(true, '', {}, {})
+      simulated_successful_billing_response
     end
 
     def source_required?
@@ -35,5 +19,11 @@ def source_required?
     def auto_capture?
       false
     end
+
+    private
+
+    def simulated_successful_billing_response(message = "")
+      ActiveMerchant::Billing::Response.new(true, message, {}, {})
+    end
   end
 end

app/models/spree/purchase_order.rb

@@ -1,7 +1,22 @@
 module Spree
-  class PurchaseOrder < ActiveRecord::Base
-    has_one :payment, as: :source
+  class PurchaseOrder < Spree::Base
+    belongs_to :payment_method
+    has_many :payments, as: :source
 
     validates_presence_of :po_number, :organization_name
+
+    def actions
+      %w(complete void)
+    end
+
+    # Indicates whether its possible to complete the payment
+    def can_complete?(payment)
+      payment.pending? || payment.checkout?
+    end
+
+    # Indicates whether its possible to void the payment.
+    def can_void?(payment)
+      !payment.failed? && !payment.void?
+    end
   end
 end

config/locales/en.yml

@@ -0,0 +1,10 @@
+en:
+  spree:
+    purchase_order: Purchase order
+  activerecord:
+    models:
+      spree/purchase_order: Purchase order
+    attributes:
+      spree/purchase_order:
+        po_number: Number
+        organization_name: Organization name

lib/spree_purchase_order/engine.rb

@@ -7,7 +7,10 @@ class Engine < ::Rails::Engine
     config.autoload_paths << "#{config.root}/lib"
 
     config.generators do |g|
-      g.test_framework :rspec
+      g.test_framework :rspec, fixture: false
+      g.fixture_replacement :factory_girl, dir: 'spec/factories'
+      g.assets false
+      g.helper false
     end
 
     def self.activate

lib/spree_purchase_order/version.rb

@@ -1,3 +1,3 @@
 module SpreePurchaseOrder
-  VERSION = '3.2.0.beta'
+  VERSION = '3.2.0.rc1'
 end

spec/dummy/Rakefile

@@ -0,0 +1,3 @@
+require File.expand_path('../config/application', __FILE__)
+
+Rails.application.load_tasks

spec/dummy/app/assets/javascripts/application.js

@@ -0,0 +1 @@
+//= require_tree .

spec/dummy/app/assets/stylesheets/application.css

@@ -0,0 +1,4 @@
+/*
+ *= require_tree .
+ *= require_self
+ */

spec/dummy/app/controllers/application_controller.rb

@@ -0,0 +1,3 @@
+class ApplicationController < ActionController::Base
+  protect_from_forgery with: :exception
+end

spec/dummy/app/helpers/application_helper.rb

@@ -0,0 +1,2 @@
+module ApplicationHelper
+end

spec/dummy/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

spec/dummy/app/views/layouts/application.html.erb

@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Dummy</title>
+  <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track' => true %>
+  <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>
+  <%= csrf_meta_tags %>
+</head>
+<body>
+
+<%= yield %>
+
+</body>
+</html>

spec/dummy/bin/bundle

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+load Gem.bin_path('bundler', 'bundle')

spec/dummy/bin/rails

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+APP_PATH = File.expand_path('../../config/application', __FILE__)
+require_relative '../config/boot'
+require 'rails/commands'

spec/dummy/bin/rake

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

spec/dummy/bin/setup

@@ -0,0 +1,22 @@
+#!/usr/bin/env ruby
+require 'pathname'
+
+# path to your application root.
+APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+
+Dir.chdir APP_ROOT do
+
+  puts "== Installing dependencies =="
+  system "gem install bundler --conservative"
+  system "bundle check || bundle install"
+
+  puts "\n== Preparing database =="
+  system "bin/rake db:setup"
+
+  puts "\n== Removing old logs and tempfiles =="
+  system "rm -f log/*"
+  system "rm -rf tmp/cache"
+
+  puts "\n== Restarting application server =="
+  system "touch tmp/restart.txt"
+end

spec/dummy/config.ru

@@ -0,0 +1,2 @@
+require ::File.expand_path('../config/environment', __FILE__)
+run Rails.application

spec/dummy/config/application.rb

@@ -0,0 +1,28 @@
+require File.expand_path('../boot', __FILE__)
+
+require "active_record/railtie"
+require "action_controller/railtie"
+require "action_mailer/railtie"
+require "action_view/railtie"
+require "sprockets/railtie"
+
+Bundler.require(*Rails.groups)
+require "spree_purchase_order"
+
+module Dummy
+  class Application < Rails::Application
+
+    config.to_prepare do
+      Dir.glob(File.join(File.dirname(__FILE__), "../app/**/*_decorator*.rb")) do |c|
+        Rails.configuration.cache_classes ? require(c) : load(c)
+      end
+
+      Dir.glob(File.join(File.dirname(__FILE__), "../app/overrides/*.rb")) do |c|
+        Rails.configuration.cache_classes ? require(c) : load(c)
+      end
+    end
+
+    config.active_record.raise_in_transactional_callbacks = true
+  end
+end
+

spec/dummy/config/boot.rb

@@ -0,0 +1,5 @@
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
+$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)

spec/dummy/config/database.yml

@@ -0,0 +1,8 @@
+default: &default
+  adapter: sqlite3
+  pool: 5
+  timeout: 5000
+
+test:
+  <<: *default
+  database: db/test.sqlite3

spec/dummy/config/environment.rb

@@ -0,0 +1,3 @@
+require File.expand_path('../application', __FILE__)
+
+Rails.application.initialize!

spec/dummy/config/environments/test.rb

@@ -0,0 +1,13 @@
+Rails.application.configure do
+  config.cache_classes = true
+  config.eager_load = false
+  config.serve_static_files   = true
+  config.static_cache_control = 'public, max-age=3600'
+  config.consider_all_requests_local       = true
+  config.action_controller.perform_caching = false
+  config.action_dispatch.show_exceptions = false
+  config.action_controller.allow_forgery_protection = false
+  config.action_mailer.delivery_method = :test
+  config.active_support.test_order = :random
+  config.active_support.deprecation = :stderr
+end

spec/dummy/config/initializers/assets.rb

@@ -0,0 +1 @@
+Rails.application.config.assets.version = '1.0'

spec/dummy/config/initializers/cookies_serializer.rb

@@ -0,0 +1 @@
+Rails.application.config.action_dispatch.cookies_serializer = :json

spec/dummy/config/initializers/filter_parameter_logging.rb

@@ -0,0 +1 @@
+Rails.application.config.filter_parameters += [:password]

spec/dummy/config/initializers/session_store.rb

@@ -0,0 +1 @@
+Rails.application.config.session_store :cookie_store, key: '_dummy_session'

spec/dummy/config/initializers/spree.rb

@@ -0,0 +1,2 @@
+Spree.config do |config|
+end

spec/dummy/config/initializers/wrap_parameters.rb

@@ -0,0 +1,3 @@
+ActiveSupport.on_load(:action_controller) do
+  wrap_parameters format: [:json] if respond_to?(:wrap_parameters)
+end