Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 781 pymatgen structure bug #782

Merged
merged 5 commits into from
Jan 17, 2025

Merge remote-tracking branch 'origin/fix-pmg' into fix-pmg

90a489b
Select commit
Loading
Failed to load commit list.
Merged

fix: 781 pymatgen structure bug #782

Merge remote-tracking branch 'origin/fix-pmg' into fix-pmg
90a489b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

85.13% (-0.01%) compared to 961b591, passed because coverage increased by 0% when compared to adjusted base (85.12%)

View this Pull Request on Codecov

85.13% (-0.01%) compared to 961b591, passed because coverage increased by 0% when compared to adjusted base (85.12%)

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (961b591) to head (90a489b).

Files with missing lines Patch % Lines
dpdata/pymatgen/structure.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #782      +/-   ##
==========================================
- Coverage   85.13%   85.13%   -0.01%     
==========================================
  Files          81       81              
  Lines        7535     7539       +4     
==========================================
+ Hits         6415     6418       +3     
- Misses       1120     1121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.