-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passing API_BASE as optional parameter for openai provider #6820
Merged
shadeMe
merged 11 commits into
deepset-ai:v1.x
from
augchan42:feature/override-api-base
Jan 30, 2024
Merged
feat: allow passing API_BASE as optional parameter for openai provider #6820
shadeMe
merged 11 commits into
deepset-ai:v1.x
from
augchan42:feature/override-api-base
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augchan42
changed the title
allow passing API_BASE as optional parameter for openai provider
feat: allow passing API_BASE as optional parameter for openai provider
Jan 25, 2024
shadeMe
requested changes
Jan 26, 2024
Co-authored-by: Madeesh Kannan <[email protected]>
Co-authored-by: Madeesh Kannan <[email protected]>
Co-authored-by: Madeesh Kannan <[email protected]>
…n42/haystack into feature/override-api-base
shadeMe
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! One more change.
Co-authored-by: Madeesh Kannan <[email protected]>
shadeMe
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API_BASE can now be passed as an optional parameter in the getting_started sample. PromptNode and PromptModel were enhanced to allow passing of this parameter.
Logging in the sample was made more verbose, I did this so people could better see what was happening under the covers. Feel free to reject this change if this isn't wanted.