Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding metadata grouper component #8512
feat: adding metadata grouper component #8512
Changes from 25 commits
0bb60f6
9d0e090
834fe32
8f224fe
ccf6080
9376b06
b6fa393
75a009b
c6b76ef
70eaec1
20e3249
39b0e80
cdc05bd
e47b4ed
a95a4f4
8a53cb1
a3dcbd8
a546939
40bece7
7feeb7a
7366dcd
44b1289
3c603b5
6572262
ecac860
7e205ef
c3c624c
a60ac03
11e5b68
4630570
1c883e4
18ed44c
23a8216
d7fab9b
bb7a710
561e9f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see problems in a simple implementation like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ju-gu can you test whether this simpler implementation is suitable for your needs? The tests are satisfied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this seems to work as well, 👍