Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openai): be tolerant to exceptions #8526

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

nilleb
Copy link
Contributor

@nilleb nilleb commented Nov 8, 2024

Related Issues

  • fixes #issue-number

Proposed Changes:

if ever an error is raised by the OpenAI API, don't fail the entire processing

How did you test it?

Manual tests

Notes for the reviewer

Checklist

if ever an error is raised by the OpenAI API, don't fail the entire processing
@nilleb nilleb requested a review from a team as a code owner November 8, 2024 20:42
@nilleb nilleb requested review from davidsbatista and removed request for a team November 8, 2024 20:42
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@silvanocerza silvanocerza requested a review from a team as a code owner November 14, 2024 17:10
@silvanocerza silvanocerza requested review from dfokina and removed request for a team November 14, 2024 17:10
@silvanocerza silvanocerza requested review from anakin87 and removed request for davidsbatista November 14, 2024 17:11
@github-actions github-actions bot added the type:documentation Improvements on the docs label Nov 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11853815480

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.246%

Files with Coverage Reduction New Missed Lines %
components/preprocessors/document_splitter.py 1 98.35%
components/embedders/openai_document_embedder.py 10 85.14%
components/preprocessors/nltk_document_splitter.py 11 94.3%
Totals Coverage Status
Change from base Build 11660533312: 0.1%
Covered Lines: 7846
Relevant Lines: 8694

💛 - Coveralls

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've found an error.

The rest is good.

@silvanocerza silvanocerza enabled auto-merge (squash) November 15, 2024 09:47
@silvanocerza silvanocerza merged commit c78545d into deepset-ai:main Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants