Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: huggingface embedder error messages not being displayed #8537

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix: huggingface embedder error messages not being displayed #8537

merged 6 commits into from
Nov 12, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Nov 12, 2024 •
edited
Loading

Proposed Changes:

  • Error messages not being displayed
  • Needed to add pylint disable too-many-arguments, since the file is changed, it's now checked

How did you test it?

  • CI tests

Checklist

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 12, 2024
@davidsbatista davidsbatista changed the title initial import fix: huggingface embedder error messages Nov 12, 2024
@davidsbatista davidsbatista changed the title fix: huggingface embedder error messages fix: huggingface embedder error messages not being displayed Nov 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11798391023

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.139%
Totals Coverage Status
Change from base Build 11781566054: 0.0%
Covered Lines: 7742
Relevant Lines: 8589
💛 - Coveralls

@davidsbatista davidsbatista marked this pull request as ready for review November 12, 2024 12:54
@davidsbatista davidsbatista requested a review from a team as a code owner November 12, 2024 12:54
@davidsbatista davidsbatista requested review from shadeMe and anakin87 and removed request for a team November 12, 2024 12:54
anakin87
anakin87 reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Can you please apply the same change to the corresponding Generator and Chat Generator?

(A minimal release note would be appreciated)

@davidsbatista
Copy link
Contributor Author

I don't think it adding a release note for this is relevant

@davidsbatista davidsbatista merged commit fcdf392 into main Nov 12, 2024
15 checks passed
@davidsbatista davidsbatista deleted the fix-error-msg branch November 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@shadeMe shadeMe Awaiting requested review from shadeMe shadeMe is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @coveralls @anakin87