Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow unverified openapi calls #8551

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

richardpaulhudson
Copy link

Proposed Changes:

With the existing code, there is no way of disabling SSL verification for OpenAPI function calls. This PR fixes this by introducing an optional initialization parameter that corresponds exactly to the openapi3 initialization parameter and that is fed through to it.

How did you test it?

I ran and fixed the unit tests and also confirmed that the fix works as intended with my own client code.

Notes for the reviewer

This page will need updating, but I was unsure how to do so to make the documentation change sync with the code change.

Checklist

@richardpaulhudson richardpaulhudson requested a review from a team as a code owner November 15, 2024 17:25
@richardpaulhudson richardpaulhudson requested review from davidsbatista and removed request for a team November 15, 2024 17:25
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ richardpaulhudson
[email protected]


[email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Nov 15, 2024
@richardpaulhudson richardpaulhudson changed the title Allow unverified openapi calls Feat: Allow unverified openapi calls Nov 15, 2024
@richardpaulhudson richardpaulhudson changed the title Feat: Allow unverified openapi calls feat: Allow unverified openapi calls Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants