Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove soak-interrupts.yaml #1714

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: remove soak-interrupts.yaml #1714

merged 1 commit into from
Jan 23, 2025

Conversation

cmwylie19
Copy link
Contributor

Description

The intention behind the soak-interrupts test was to test the informer pattern by disconnecting the watch and using the LAST_SEEN_TIME and relist to trigger trigger fetch calls against watch resources t update the ephemeral informer cache and dispatch missed events.

There is currently no way to "turn off" the watch connection without also turning off the "list" which both communicate to the kube-apiserver. If there were a way it would need to be a new feature in KFC.

The way this test is written now it scales down the Pepr pod and brings it back up and expects the events to be processed. This case is tested in nearly every excellent example that has a watch and in the UDS test. There is nothing unique about this test.

Related Issue

Fixes #1708

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Sorry, something went wrong.

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 requested a review from a team as a code owner January 23, 2025 16:15
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (26989a0) to head (38d921e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files          48       48           
  Lines        2082     2082           
  Branches      450      459    +9     
=======================================
  Hits         1654     1654           
  Misses        398      398           
  Partials       30       30           

Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed sync as a team, this is good to remove.

@samayer12 samayer12 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 01c7660 Jan 23, 2025
48 checks passed
@samayer12 samayer12 deleted the 1708 branch January 23, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

soak interrupts test a standalone running test
2 participants