Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Updates #31

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Python 3 Updates #31

wants to merge 11 commits into from

Conversation

mlavin
Copy link

@mlavin mlavin commented Feb 9, 2018

This builds off of the previous WIP for Python 3 and uses a version of python-keyczar which supports Python 3. Everything seems to work correctly on Python 3.5 and Django 1.11 but admittedly I haven't tested other Django versions or Python 2.

@mlavin
Copy link
Author

mlavin commented Feb 9, 2018

Looks like this breaks Python 2 ¯_(ツ)_/¯

Copy link

@jamespeacock jamespeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes that I have been looking for in order to make this library Python3 compatible. Thank you for getting rid of types and switching to six!

@jamespeacock
Copy link

It seems like your changes could be a fork for a REAL python 3 version of encrypted fields...
With the python3 changes to strings/bytes/unicode, it seems unreasonable to make the encryption library backwards compatible rather than just forking and hosting a separate python3 version, imo!

@jamespeacock
Copy link

@mlavin If you haven't discovered this on your own yet, you don't need this guy's package anymore as django-extensions 2.0.0 and above offers encrypted fields support.

@kopf kopf mentioned this pull request Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants