Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 46 support #223

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Gnome 46 support #223

wants to merge 10 commits into from

Conversation

jekkos
Copy link

@jekkos jekkos commented Sep 15, 2024

This version adds support for Gnome 46. Beside the metadata changa the 'add_actorandremove_actor` methods needed to be renamed.

@jekkos jekkos mentioned this pull request Sep 15, 2024
@jekkos
Copy link
Author

jekkos commented Oct 18, 2024

Could you merge the PR ? seems I don't have write access.

@pdelteil
Copy link

@jekkos I also don't have writing access.

@Jertec
Copy link

Jertec commented Dec 4, 2024

Do we know who does? and if not, does it make sense to start a fork?

Also, does anyone know if anyone is taking on adding 47 support?

@andrzej-az
Copy link

Is there any plans to publish it in gnome extensions? dont actually want to create fork by myself, prefer to help in existing one.
@jekkos @sharkguto maybe you would like to create a fork and publish it?

@fin-ger
Copy link
Member

fin-ger commented Jan 18, 2025

Publishing on Gnome Extensions is very hard, as they randomly claim source changes upon upload which can result in quite extensive refactorings of the code. However, when reapplying the same release bundle a couple of weeks later it might just pass. You don't really know beforehand. Additionally, the Gnome shell extensions release bundle can only be uploaded by @martin31821 because the extensions website (afaik...) does not support organizations or invites to projects for other members.

So, TL;DR: releasing on Gnome extensions is very unlikely. It is too much work, too unpredictable and depends on @martin31821 limited time for handling the communication.

Regarding a merge to the main repo: I'm very glad you are putting so much effort into pporting this extension. My experience is that the settings dialog and dropdown menu break with every Gnome release and it is such a daunting task to keep up with the Gnome releases. Especially because all the distros have differing Gnome versions and might also have different behavior in the the same Gnome version (especially with Ubuntu). Testing all of this before a release is very time consuming. I currently just do not have this time, although I would love to. Publishing a new release in the main repo with not properly tested code under Fedora, Ubuntu (LTS and latest), Debian and Arch will result in an influx of bug reports. I shy away from creating a new release myself, because I simply do not have the time to handle the bug reports and test the code properly. Until noone steps in for maintaining this and handling all the community communications I think having the open PRs on this main repo is the best approach, as people who know how to get this to work are usually also capable of handling the problems that arise when these PRs are not a "one-click install and everything just works".

If someone is interested in maintaining this project, just contact me. We can figure something out.

@pdelteil
Copy link

Publishing on Gnome Extensions is very hard, as they randomly claim source changes upon upload which can result in quite extensive refactorings of the code. However, when reapplying the same release bundle a couple of weeks later it might just pass. You don't really know beforehand. Additionally, the Gnome shell extensions release bundle can only be uploaded by @martin31821 because the extensions website (afaik...) does not support organizations or invites to projects for other members.

So, TL;DR: releasing on Gnome extensions is very unlikely. It is too much work, too unpredictable and depends on @martin31821 limited time for handling the communication.

Regarding a merge to the main repo: I'm very glad you are putting so much effort into pporting this extension. My experience is that the settings dialog and dropdown menu break with every Gnome release and it is such a daunting task to keep up with the Gnome releases. Especially because all the distros have differing Gnome versions and might also have different behavior in the the same Gnome version (especially with Ubuntu). Testing all of this before a release is very time consuming. I currently just do not have this time, although I would love to. Publishing a new release in the main repo with not properly tested code under Fedora, Ubuntu (LTS and latest), Debian and Arch will result in an influx of bug reports. I shy away from creating a new release myself, because I simply do not have the time to handle the bug reports and test the code properly. Until noone steps in for maintaining this and handling all the community communications I think having the open PRs on this main repo is the best approach, as people who know how to get this to work are usually also capable of handling the problems that arise when these PRs are not a "one-click install and everything just works".

If someone is interested in maintaining this project, just contact me. We can figure something out.

Hello there @fin-ger,

Thank you for your detailed explanation. I didn't know publishing an extension to Gnome Ext can be so time consuming.

This extension is very useful for me (Ubuntu). I have some spare time that I could put into the effort to make the extension compatible with the latest Gnome versions and Linux distros.

@andrzej-az
Copy link

@fin-ger confirm everything. the rewiev took a week, here is the 1st result https://extensions.gnome.org/review/61695
I think, i'll do just another attempt. any help welcome

@sharkguto
Copy link

Is there any plans to publish it in gnome extensions? dont actually want to create fork by myself, prefer to help in existing one. @jekkos @sharkguto maybe you would like to create a fork and publish it?

I confess that I'm a bit disappointed with Gnome, as I use OpenSUSE Tumbleweed I changed to KDE and I'm using my custom plugin based on cpupower but with QT. The day I finish it I'll publish on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants