Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

feat: add toggles to consent options #78

Merged
merged 1 commit into from
Aug 22, 2021
Merged

feat: add toggles to consent options #78

merged 1 commit into from
Aug 22, 2021

Conversation

pixelass
Copy link
Member

allows setting each consent category separately

@vercel
Copy link

vercel bot commented Aug 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dekk/homepage/BjaoENM4odSjZJQsRCkxz8PoJDQm
✅ Preview: https://homepage-git-feat-toggle-for-consent-dekk.vercel.app

@pixelass pixelass force-pushed the feat/toggle-for-consent branch from 50dda56 to bc514d5 Compare August 22, 2021 13:54
@pixelass pixelass requested review from 0x04 and TimPietrusky August 22, 2021 13:57
0x04
0x04 reviewed Aug 22, 2021
View reviewed changes
src/atoms/toggle/styled.ts
export const StyledInput = styled.input<StyledInputProps>`
position: absolute;
top: 0;
right: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it would be better, to leave the input in place and use appearance: none instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe and cross-browser compatible. I had an overflown hidden on this before but removed removed it when I was playing around with the focus styles. I think it's safe to add the overflow hidden hack again. I'll check.
AFAIK appearance: none is not reliable in all browsers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm fine with that.

feat: add toggles to consent options
78d9ca4 
allows setting each consent category separately
@pixelass pixelass force-pushed the feat/toggle-for-consent branch from bc514d5 to 78d9ca4 Compare August 22, 2021 15:02
@pixelass pixelass merged commit 52efb2b into main Aug 22, 2021
@pixelass pixelass deleted the feat/toggle-for-consent branch August 22, 2021 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0x04 0x04 0x04 approved these changes

@TimPietrusky TimPietrusky Awaiting requested review from TimPietrusky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixelass @0x04