Fixed provider and view to get correct viewRange and absoluteRange #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes to this PR:
The unitController is 0-based. So, the viewRange (the visible range of the chart) should be between 0 and the absoluteRange (the total length of the chart).
Since in this example the chart begins far more later than 0 we have to take that value and say thats the logical 0. So we have to normalise everything by subtracting that start value from all other values of rows and states.
If you need the original time in the time axis you can adapt the number in the numberTranslator again.
I have enhanced the TimelineChart.TimeGraphModel with a data field so one can transport such information.
One more thing: I had to use the type 'any' for states because the type 'TimeGraphState' in the tsp-typescript model isn't the same as the state object returned by the server. -> the TimeGraphState in tsp-ts-client needs endTime while the server provides an object with duration instead.