Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:add codeowners template #5

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

sljory
Copy link

@sljory sljory commented Apr 6, 2023

Why?

This PR has been raised by the Product Security Engineering team as no CODEOWNERS file was found in this repository. The benefit of the CODEOWNERS file is to be able to easily identify who owns this code and enables automatic peer reviewer assignment when a PR is raised.


What you need to do (How to review)?

Currently the CODEOWNERS is blank.

  1. Please edit the file to add in the name of the codeowner(s)
  2. Merge the PR

If this PR was raised by mistake and a CODEOWNERS file is not needed, feel free to close this PR.


Further info

Guidance on the syntax is included in the github CODEOWNERS Documentation

JIRA: PSC-824

@sljory sljory self-assigned this Apr 6, 2023
@sljory sljory requested a review from scott-ad-riley December 8, 2023 13:04
@nudgebot-stable
Copy link

Not notifying user scott-ad-riley. User has Nudgebot notifications muted.

@scott-ad-riley
Copy link
Member

This internal ruby gem is only used by direct-payments to sign XML that we send to citibank. The payments team are the owners of that service which is why I've made us owners of this library too.

@scott-ad-riley scott-ad-riley merged commit 369ce64 into master Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants