Skip to content

Commit

Permalink
Fix shellcheck warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
akorn committed Feb 24, 2025
1 parent 1265f10 commit f2a29ed
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions dkms.in
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ get_module_verinfo(){
local vals
vals=
while read -ra vals; do
[[ $vals ]] || continue
[[ ${vals[0]} ]] || continue
case "${vals[0]}" in
version:)
ver="${vals[1]}"
Expand Down Expand Up @@ -1989,9 +1989,9 @@ module_status_weak() {
else
continue
fi
IFS=/ read m v k a <<<"$(IFS=$oifs find_module_from_ko "$weak_ko")"
IFS=/ read -r m v k a <<<"$(IFS=$oifs find_module_from_ko "$weak_ko")"
[[ $m ]] || continue
kern=${weak_ko#$install_tree/}
kern=${weak_ko#"$install_tree"/}
kern=${kern%/weak-updates/*}
[[ $m = "${1:-*}" && $v = "${2:-*}" && $k = "${5:-*}" && $a = "${4:-*}" && $kern = "${3:-*}" ]] || continue
already_found[$m/$v/$kern/$a/$k]+=${weak_ko##*/}" "
Expand Down Expand Up @@ -2023,7 +2023,7 @@ do_status_weak()
local status
while read -r status mvka; do
[[ $status ]] || continue
IFS=/ read m v k a kern <<< "$mvka"
IFS=/ read -r m v k a kern <<< "$mvka"
echo "$m, $v, $k, $a: installed-weak from $kern"
done <<< "$(module_status_weak "$@")"
}
Expand Down Expand Up @@ -2439,7 +2439,7 @@ run_match()
fi
maybe_build_module "$template_module" "$template_version" "$kernelver" "$arch"
maybe_install_module "$template_module" "$template_version" "$kernelver" "$arch"
done <<< "$(echo "$template_kernel_status")"
done <<< "$template_kernel_status"
}

report_build_problem()
Expand Down Expand Up @@ -2579,7 +2579,7 @@ autoinstall() {
# a list of modules and their latest version.
while read -r status mvka; do
[[ $status ]] || continue
IFS='/' read m v k a <<< "$mvka"
IFS='/' read -r m v k a <<< "$mvka"
# If the module status is broken there is nothing that can be done
if [[ $status = broken ]]; then
error "$m/$v is broken! Missing the source directory or the symbolic link pointing to it."\
Expand Down

0 comments on commit f2a29ed

Please sign in to comment.