Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify input types for PrettyPrinter with a generator #194

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

shartse
Copy link

@shartse shartse commented Mar 3, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Resolves #159

I'm planning on continuing the work in #190 to add input type checking to all commands, but I wanted to get the core bug-fix in first.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@shartse shartse force-pushed the fix-pretty-print branch from 57bfdb6 to 4ce1459 Compare March 3, 2020 22:35
@shartse shartse merged commit 0ea73b6 into delphix:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PrettyPrinter is invoked one object at a time
3 participants