Set default of includeEndStreamAction to false (#597)

delta-io · Oct 11, 2024 · f8d5720 · f8d5720
1 parent e77f0f8
commit f8d5720
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/client/src/main/scala/io/delta/sharing/client/DeltaSharingClient.scala b/client/src/main/scala/io/delta/sharing/client/DeltaSharingClient.scala
@@ -186,7 +186,7 @@ class DeltaSharingRestClient(
     readerFeatures: String = "",
     queryTablePaginationEnabled: Boolean = false,
     maxFilesPerReq: Int = 100000,
-    endStreamActionEnabled: Boolean = true,
+    endStreamActionEnabled: Boolean = false,
     enableAsyncQuery: Boolean = false,
     asyncQueryPollIntervalMillis: Long = 10000L,
     asyncQueryMaxDuration: Long = 600000L,

diff --git a/client/src/main/scala/io/delta/sharing/client/util/ConfUtils.scala b/client/src/main/scala/io/delta/sharing/client/util/ConfUtils.scala
@@ -40,7 +40,7 @@ object ConfUtils {
   val USE_ASYNC_QUERY_DEFAULT = "false"
 
   val INCLUDE_END_STREAM_ACTION_CONF = "spark.delta.sharing.query.includeEndStreamAction"
-  val INCLUDE_END_STREAM_ACTION_DEFAULT = "true"
+  val INCLUDE_END_STREAM_ACTION_DEFAULT = "false"
 
   val TIMEOUT_CONF = "spark.delta.sharing.network.timeout"
   val TIMEOUT_DEFAULT = "320s"

diff --git a/client/src/test/scala/io/delta/sharing/client/util/ConfUtilsSuite.scala b/client/src/test/scala/io/delta/sharing/client/util/ConfUtilsSuite.scala
@@ -84,18 +84,20 @@ class ConfUtilsSuite extends SparkFunSuite {
   }
 
   test("includeEndStreamAction") {
-    assert(includeEndStreamAction(newConf()) == true)
+    assert(includeEndStreamAction(newConf()) == false)
+    assert(includeEndStreamAction(newConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "true"))) == true)
     assert(includeEndStreamAction(newConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "false"))) == false)
-    assert(includeEndStreamAction(newConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "random"))) == true)
+    assert(includeEndStreamAction(newConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "rdm"))) == false)
 
-    assert(includeEndStreamAction(newSqlConf()) == true)
+    assert(includeEndStreamAction(newSqlConf()) == false)
+    assert(
+      includeEndStreamAction(newSqlConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "true"))) == true
+    )
     assert(
       includeEndStreamAction(newSqlConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "false"))) == false
     )
     intercept[IllegalArgumentException] {
-      assert(
-        includeEndStreamAction(newSqlConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "random"))) == false
-      )
+      includeEndStreamAction(newSqlConf(Map(INCLUDE_END_STREAM_ACTION_CONF -> "random")))
     }.getMessage.contains(INCLUDE_END_STREAM_ACTION_CONF)
   }
 

diff --git a/spark/src/test/scala/io/delta/sharing/spark/TestDeltaSharingClient.scala b/spark/src/test/scala/io/delta/sharing/spark/TestDeltaSharingClient.scala
@@ -47,7 +47,7 @@ class TestDeltaSharingClient(
     readerFeatures: String = "",
     queryTablePaginationEnabled: Boolean = false,
     maxFilesPerReq: Int = 10000,
-    endStreamActionEnabled: Boolean = true,
+    endStreamActionEnabled: Boolean = false,
     enableAsyncQuery: Boolean = false,
     asyncQueryPollIntervalMillis: Long = 1000L,
     asyncQueryMaxDuration: Long = Long.MaxValue,