[Kenrnel][Test only] Refactor and move method to generate protocol, metadata, schema to a separate class. #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
raveeram-db
approved these changes
Feb 21, 2025
allisonport-db
approved these changes
Feb 21, 2025
vkorukanti
requested changes
Feb 21, 2025
| * */ | ||
| trait TableMetadataTestUtils { | ||
|
|
||
| def createTestProtocol(minWriterVersion: Int, writerFeatures: String*): Protocol = { |
There was a problem hiding this comment.
this is not a generic utility. Better to change it to take everything (minReaderVersion, minWriterVersion) or (minReaderVersion, minWriterVersion, readerFeatures, writerFeatures). Otherwise this is a specific case created for TableFeaturesSuite.scala. Also this is going away in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
No prod code change, just refactor and move method to generate protocol, metadata, schema to a separate class. These utils could be shared in other case such as #4134
How was this patch tested?
Existing
Does this PR introduce any user-facing changes?
No