[Spark] Recognize java8api date format in query optimizations #4201 #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #4201
The convertValueIfRequired function casts DateType columns to java.sql.Date. Optimizing subqueries involving date columns with spark.sql.datetime.java8API.enabled set to true currently results in ClassCastException errors. This fix correctly converts dates regardless of the java type of the date value.
How was this patch tested?
A unit test was added to verify that the optimizations now work regardless of the value of the spark.sql.datetime.java8API.enabled configuration (without this fix the unit test is failing).
Does this PR introduce any user-facing changes?
No