Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceNow - append syslog transactions logs #36880

Merged
merged 49 commits into from
Nov 18, 2024

Conversation

inbalapt1
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11802

Description

Update the ServiceNow Event Collector to add "syslog_transactions"

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Oct 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ServiceNow/Integrations/ServiceNowEventCollector
   ServiceNowEventCollector.py104595%41–42, 44, 49, 55
TOTAL104595% 

Tests Skipped Failures Errors Time
148 0 💤 0 ❌ 0 🔥 8.995s ⏱️

@inbalapt1 inbalapt1 self-assigned this Oct 30, 2024
@inbalapt1 inbalapt1 added the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Oct 30, 2024
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.6.12.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.6.13.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt go over the tests yet. please assign a tech reviewer as well
Over all great job!

@ShirleyDenkberg
Copy link
Contributor

@omerKarkKatz Doc review completed.

@omerKarkKatz omerKarkKatz self-requested a review November 18, 2024 09:25
@inbalapt1 inbalapt1 removed the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Nov 18, 2024
@inbalapt1 inbalapt1 merged commit a6d282e into master Nov 18, 2024
18 checks passed
@inbalapt1 inbalapt1 deleted the ia_service-now-event-collector branch November 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants