Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QualysFIM events and incidents API endpoints to V2 and V3 #37188

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

kamalq97
Copy link
Contributor

@kamalq97 kamalq97 commented Nov 12, 2024

Related Issues

fixes: link to the issue

Description

  • Update the QualysFIM integration to use the get events API v2 and get incidents v3 (all usages of the now defunct API v1 have been updated)
  • Improve existing unit tests and add new ones

@kamalq97 kamalq97 self-assigned this Nov 12, 2024
@kamalq97 kamalq97 added python Pull requests that update Python code ignore-auto-bump-version Not to run autobump release notes job on this pr. labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/QualysFIM/Integrations/QualysFIM
   QualysFIM.py2514681%59–60, 70, 388, 391, 394, 416, 419, 468, 513, 519, 576, 584, 588, 602, 607, 618, 640–645, 649, 656–659, 661, 663, 665–669, 675, 685–686, 688–689, 696–697, 699–700, 702–703
TOTAL2514681% 

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 8.748s ⏱️

@kamalq97 kamalq97 marked this pull request as ready for review November 14, 2024 13:40
@kamalq97 kamalq97 changed the title Update QualysFIM events and incidents API endpoints to V2 Update QualysFIM events and incidents API endpoints to V2 and V3 Nov 14, 2024
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM_test.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM_test.py Outdated Show resolved Hide resolved
Packs/QualysFIM/ReleaseNotes/1_0_34.md Outdated Show resolved Hide resolved
Packs/QualysFIM/pack_metadata.json Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@dorschw Doc review completed.

Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM_test.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM_test.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM_test.py Outdated Show resolved Hide resolved
Packs/QualysFIM/Integrations/QualysFIM/QualysFIM.py Outdated Show resolved Hide resolved
@kamalq97 kamalq97 removed the ignore-auto-bump-version Not to run autobump release notes job on this pr. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants