Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4 edits #71

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Conversation

dankamongmen
Copy link
Contributor

notes:

  • table 4.1: it seems L1 divides by 4 while the others divide by 2
  • 4-7: you say all_loads = fb_hit + l1_hit + l1_miss, but your table has

29580 mem_load_retired.fb_hit
19036 mem_load_retired.l1_miss
497204 mem_load_retired.l1_hit

[schwarzgerat](0) $ echo $((29580 + 19036 + 497204))
545820
[schwarzgerat](0) $

but you have:

546230 mem_inst_retired.all_loads

leaving 410 unexplained

  • 4.8: again, i think it predicts target, not direction
  • don't like equating branch prediction and speculative execution. you can have BP without SE (for just fetch, for instance).

Copy link
Contributor Author

@dankamongmen dankamongmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalized a lot of capitalization and units, leading to some bulk. called out things inline and in the PR notes.

@dendibakh dendibakh self-assigned this Sep 14, 2024
@dendibakh dendibakh self-requested a review September 14, 2024 20:47
@dendibakh
Copy link
Owner

@dankamongmen

notes:

  • table 4.1: it seems L1 divides by 4 while the others divide by 2

Not sure if you want me to change anything in that table. Please let me know.

  • 4-7: you say all_loads = fb_hit + l1_hit + l1_miss, but your table has

29580 mem_load_retired.fb_hit 19036 mem_load_retired.l1_miss 497204 mem_load_retired.l1_hit

[schwarzgerat](0) $ echo $((29580 + 19036 + 497204))
545820
[schwarzgerat](0) $

but you have:

546230 mem_inst_retired.all_loads

leaving 410 unexplained

Yeah, this is the artifact of using performance counters. The numbers may not exactly match. I will add a footnote about it in a separate commit.

  • 4.8: again, i think it predicts target, not direction

Agree.

  • don't like equating branch prediction and speculative execution. you can have BP without SE (for just fetch, for instance).

Agree. But did I make this mistake in this chapter? I don't remember seeing this.

@dendibakh dendibakh merged commit 1ac2b43 into dendibakh:main Sep 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants