Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 5 edits #72

Merged
merged 13 commits into from
Sep 24, 2024
Merged

Conversation

dankamongmen
Copy link
Contributor

A lot of numbers here were using apostrophes as their grouping element. I changed those to commas, or removed them entirely when they were literals.

Made perf be perf everywhere.

"Pseudo names" -> "pseudonyms".

"libfm4" -> "libpfm4"

Usual en dashes, comma splices, etc. This chapter was pretty clean.

Notes:

  • Listing 5.2: i would make those autos const
  • 5-3: "don't have root in a virtualized environment" in a virtualized environment, one typically does have root (though the PMCs might not be exported to the VM). in operating system level virtualization (i.e. a container) one commonly lacks root, sure. I guess you explain this later.

@dendibakh dendibakh self-requested a review September 24, 2024 16:23
@@ -8,4 +8,4 @@
- scenario 3: you're evaluating three different compression algorithms and you want to know what types of performance bottlenecks (memory latency/bandwidth, branch mispredictions, etc) each of them has.
- scenario 4: there is a new shiny library that claims to be faster than the one you currently have integrated into your project; you've decided to compare their performance.
- scenario 5: you were asked to analyze the performance of some unfamiliar code, which involves a hot loop; you want to know how many iterations the loop is doing.
2. Run the application that you're working with daily. Practice doing performance analysis using the approaches we discussed in this chapter. Collect raw counts for various CPU performance events, find hotspots, collect roofline data, and generate and study the compiler optimization report for the hot function(s) in your program.
2. Run an application that you're working with daily. Practice doing performance analysis using the approaches we discussed in this chapter. Collect raw counts for various CPU performance events, find hotspots, collect roofline data, and generate and study the compiler optimization report for the hot function(s) in your program.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here should be the, not an, no?

@dendibakh dendibakh merged commit 396d7a5 into dendibakh:main Sep 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants