Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license in all sub-packages to reflect top level license of Apache 2.0 #3975

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

github-user-23
Copy link
Contributor

Validating license change

Checked that there are no hits for

AFFERO

Checked that there are no hits for

GPLv3

Validating build

./setup.sh

Ran:

./watch.sh

Note there is a pre-existing error in watch output

@dendronhq/common-test-utils: ../../node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(99,5): error TS2411: Property '[Symbol.unscopables]' of type '() => { copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: boolean; values: boolean; }' is not assignable to 'symbol' index type 'CommentToken'.
@dendronhq/common-test-utils: 9:00:55 AM - Found 2 errors. Watching for file changes.

Was able to get the same exact error from origin/master

@dendronhq/common-test-utils: ../../node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts(99,5): error TS2411: Property '[Symbol.unscopables]' of type '() => { copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: boolean; values: boolean; }' is not assignable to 'symbol' index type 'CommentToken'.
@dendronhq/common-test-utils: 9:02:41 AM - Found 2 errors. Watching for file changes.

Hence, deeming it as unrelated to this change.

@kevinslin kevinslin merged commit 3ff66aa into dendronhq:master Apr 17, 2024
2 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants