fix(Database): do not set create: true if readonly is set to true (fix …

…#93)
denodrivers · Feb 24, 2023 · 9aa0c1a · 9aa0c1a
1 parent 4cb7e8f
commit 9aa0c1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/database.ts b/src/database.ts
@@ -209,7 +209,7 @@ export class Database {
         flags |= SQLITE3_OPEN_READWRITE;
       }
 
-      if (options.create ?? true) {
+      if ((options.create ?? true) && !options.readonly) {
         flags |= SQLITE3_OPEN_CREATE;
       }
     }

diff --git a/test/test.ts b/test/test.ts
@@ -39,6 +39,11 @@ Deno.test("sqlite", async (t) => {
     Deno.removeSync("test-path.db");
   });
 
+  await t.step("open (readonly)", () => {
+    const db = new Database(":memory:", { readonly: true });
+    db.close();
+  });
+
   let db!: Database;
   await t.step("open (url)", () => {
     db = new Database(DB_URL, { int64: true });