Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update styles for 404 page #1864

Merged
merged 2 commits into from
Jan 23, 2024
Merged

update styles for 404 page #1864

merged 2 commits into from
Jan 23, 2024

Conversation

tjheffner
Copy link
Contributor

Page to edit

url: any 404 page

Origin of request (internal/stakeholder/user feedback)

https://dsva.slack.com/archives/CBU0KDSB1/p1704994672158839

Regression on the global 404 page was discovered. It was referencing one-off styles that were removed from Formation. The markup has been updated to use classes available in the design system.

Description of what's needed (edits/link changes/additions)

The va.gov-content 404.md page that includes this template has also been updated in this PR: department-of-veterans-affairs/vagov-content#902

@randimays
Copy link
Contributor

@tjheffner Do we need to merge the vagov-content PR first in order to see the styles updated on this review instance?

@tjheffner
Copy link
Contributor Author

tjheffner commented Jan 12, 2024

@randimays to see the updates for the search form on the 404 yeah, that one would probably need to be merged first. but afaik there's no good way to test vagov-content updates besides checking both branches out locally and doing a local content build 🙃

without merging that pr first, review instances for this branch would only have updates to the "common and popular" portion of the template.

fwiw, the styles + markup between these two PRs are the same as the changes to the 404 page in next-build & this other app's not found page

Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @tjheffner!

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/404-updates January 17, 2024 17:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants