Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 17904 - Remove Lovell switcher include in VBA pages #2197

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Jul 23, 2024

Summary

  • Remove the Lovell switcher include in template for VBA
  • Sitewide team

Related issue(s)

Testing done

  • Checked VBA facility (Portland) post change
  • Go to VBA page, there should be no difference visibly or code-wise

Screenshots

No rendered code changes, only liquid changes

What areas of the site does it impact?

VBA Page liquid templates

Acceptance criteria

  • Lovell code should not appear in VBA templates

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed (N/A)

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

View template and rendered page. See that rendered page does not change (either on local dev or RI)

E.g. compare
http://3d87d1c04b6d897bac2787eb7bccfe54.review.vetsgov-internal/portland-va-regional-benefit-office/
and
https://va.gov/portland-va-regional-benefit-office/

@eselkin eselkin marked this pull request as ready for review July 23, 2024 19:36
@eselkin eselkin requested a review from a team as a code owner July 23, 2024 19:36
@eselkin eselkin merged commit 441f01e into main Jul 24, 2024
27 checks passed
@eselkin eselkin deleted the VACMS-17904-remove-Lovell-code-from-vba-layout branch July 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants