VACMS-18522 Education social right rail custom events removal #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
commented
Jul 29, 2024
| @@ -6,129 +6,98 @@ | |||
| See https://help.shopify.com/themes/liquid/tags/theme-tags#include | |||
There was a problem hiding this comment.
A lot of auto-formatting took place here. The only changes I made are to the <va-link>s.
va-vfs-bot
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
Note:
Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove custom GA events from social media links on the right rail of the Resources for Schools page (
/school-administrators).Related issue(s)
Testing done
Tested locally at http://localhost:3002/school-administrators/.
Screenshots
Education service on Facebook link
VBA on Facebook link
VBA on Instagram link
VBA on YouTube link
What areas of the site does it impact?
/school-administratorsonly. This markdown file is used to build this page: https://github.com/department-of-veterans-affairs/vagov-content/blob/main/pages/school-administrators.md?plain=1 andmerger-social-sco.htmlis part of the parent template (education-sco.html).