Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18464 Show all topics by default on Resources & Support landing page #2226

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Aug 5, 2024

Summary

The new Family Member and Caregiver Benefit Hub was recently published and we want users to be able to see the links on the Resources & Support landing page (under "Browse by topic").

Currently, that section is truncated down to 6 link lists, so we are removing the truncation and the "Show all topics" button completely from the Lists of Links component.

It was determined that the Resources & Support landing page is the only prod page where this component is used so we can safely modify it for that route specifically (/resources).

Ticket comments for context:

Related issue(s)

Testing done

This can be tested on Tugboat: https://web-w4azz2khpzdi53uymp1gxkpi0fbqdlqu.demo.cms.va.gov/resources/

  1. Check /resources locally to be sure there are link lists matching the selected categories in Drupal for this page:
Screenshot 2024-08-05 at 1 34 31 PM
  1. Be sure sort order (alphabetically) of categories is preserved; note that links within each category are not alphabetized and should match the order shown in prod
  2. Click some (or all) of the links within the sections to be sure link behavior is preserved
  3. Validate that there is no "Show all topics" button on /resources
  4. Check mobile for the above steps

Screenshots

DESKTOP - Resources & Support landing page Screenshot 2024-08-05 at 2 10 38 PM
MOBILE - Resources & Support landing page Screenshot 2024-08-05 at 1 47 54 PM Screenshot 2024-08-05 at 1 48 07 PM Screenshot 2024-08-05 at 2 11 00 PM

What areas of the site does it impact?

Resources & Support landing page (/resources)

Acceptance criteria

  • New topic has capability of being shown without hidden content shown after button is clicked
  • Sort order is preserved
  • Design review
  • Accessibility review

@randimays randimays force-pushed the 18464-rs-categories branch from f589e73 to 5b73178 Compare August 5, 2024 19:25
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/18464-rs-categories August 5, 2024 19:28 Inactive
@randimays randimays marked this pull request as ready for review August 6, 2024 15:37
@randimays randimays requested a review from a team as a code owner August 6, 2024 15:37
@randimays randimays marked this pull request as draft August 6, 2024 15:37
@randimays randimays marked this pull request as ready for review August 6, 2024 18:42
@randimays randimays marked this pull request as draft August 6, 2024 18:42
@randimays randimays force-pushed the 18464-rs-categories branch from 5b73178 to 79df33e Compare August 6, 2024 20:31
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/18464-rs-categories August 6, 2024 20:37 Inactive
@randimays randimays force-pushed the 18464-rs-categories branch from 79df33e to 2d45daf Compare August 8, 2024 14:44
@randimays
Copy link
Contributor Author

@laflannery @thejordanwood This is ready for your review please. Tugboat here for testing since RIs are down: https://web-w4azz2khpzdi53uymp1gxkpi0fbqdlqu.demo.cms.va.gov/resources/

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@randimays
Copy link
Contributor Author

Whoohoo, review instance is up!

Copy link

@thejordanwood thejordanwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@laflannery
Copy link

@randimays the RI isn't working anymore for me so I used the Tugboat, 2 things:

  1. The order of the categories isn't matching the FE but I'm not sure if maybe this was reordered since it was built.

Drupal
image
Front end
image

  1. I didn't know the "Go to all articles" was managed in Drupal. These are duplicative links and it would be better if they were unique - For example, "Go to all disability articles", Go to all burials and memorials articles", etc. Are we able to change that within the scope of this ticket or would this need approve from folks?

@randimays
Copy link
Contributor Author

@laflannery Thanks for the review!

  1. If I understood the ticket correctly, we are to maintain the existing sort order (alphabetical) on the front end.

Drupal editing screen shows listed in user-specified order. FE is alphabetical with exception of first and last ones, and truncated to limit to 6 categories.

I think Fran's comment here (and Daniel's subsequent reply) confirm this.

  1. I didn't know the "Go to all articles" was managed in Drupal. These are duplicative links and it would be better if they were unique - For example, "Go to all disability articles", Go to all burials and memorials articles", etc. Are we able to change that within the scope of this ticket or would this need approve from folks?

I have no problem with it being part of the scope of this ticket and wouldn't think there'd be any pushback but I think we should confirm with @FranECross for awareness.

@laflannery Are you ok if we merge this PR either way? Those Drupal changes will start at prod and propagate down through lower environments so we won't necessarily benefit from holding this PR until they do.

@laflannery
Copy link

Gotcha, yes that all makes sense. I shall approve, thanks!

@randimays randimays merged commit ecba42c into main Aug 12, 2024
26 checks passed
@randimays randimays deleted the 18464-rs-categories branch August 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants