-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18464 Show all topics by default on Resources & Support landing page #2226
Conversation
f589e73
to
5b73178
Compare
5b73178
to
79df33e
Compare
79df33e
to
2d45daf
Compare
2d45daf
to
7073fc6
Compare
@laflannery @thejordanwood This is ready for your review please. Tugboat here for testing since RIs are down: https://web-w4azz2khpzdi53uymp1gxkpi0fbqdlqu.demo.cms.va.gov/resources/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Whoohoo, review instance is up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@randimays the RI isn't working anymore for me so I used the Tugboat, 2 things:
|
@laflannery Thanks for the review!
I think Fran's comment here (and Daniel's subsequent reply) confirm this.
I have no problem with it being part of the scope of this ticket and wouldn't think there'd be any pushback but I think we should confirm with @FranECross for awareness. @laflannery Are you ok if we merge this PR either way? Those Drupal changes will start at prod and propagate down through lower environments so we won't necessarily benefit from holding this PR until they do. |
Gotcha, yes that all makes sense. I shall approve, thanks! |
Summary
The new Family Member and Caregiver Benefit Hub was recently published and we want users to be able to see the links on the Resources & Support landing page (under "Browse by topic").
Currently, that section is truncated down to 6 link lists, so we are removing the truncation and the "Show all topics" button completely from the Lists of Links component.
It was determined that the Resources & Support landing page is the only prod page where this component is used so we can safely modify it for that route specifically (
/resources
).Ticket comments for context:
Related issue(s)
Testing done
This can be tested on Tugboat: https://web-w4azz2khpzdi53uymp1gxkpi0fbqdlqu.demo.cms.va.gov/resources/
/resources
locally to be sure there are link lists matching the selected categories in Drupal for this page:/resources
Screenshots
DESKTOP - Resources & Support landing page
MOBILE - Resources & Support landing page
What areas of the site does it impact?
Resources & Support landing page (
/resources
)Acceptance criteria