-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS 18724 - Adds mission explainer to Vet Centers #2307
Conversation
The RI doesn't have the change or the Vet Center on the RI CMS doesn't have the centralized content. |
We may want some vertical space between the mission explainer box and the "On this page" component since the OTP component has a border on mobile. @thejordanwood |
@randimays I agree. Can we get 32px (vads-spacing-4) between the mission explainer and the "On this page" component on mobile? |
Yep, probably a margin of that size on the bottom. will add. Just on mobile only though? @thejordanwood |
@eselkin Yes, just for mobile. I think desktop looks fine. |
Since the box and no margin starts beneath 768px (medium-screen), I made the margin 4 (32px) below medium screen, and 0 otherwise. @randimays after it builds again I'll ping you (probably tomorrow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@laflannery @thejordanwood flagging: this ticket has Design / A11y review in ACs, and I'm not sure if you've seen it yet. It exists if you'd like to take a look, though. |
JK, the RI is down. Ugh. We'll have to fix that up first. |
I re-ran the Jenkins job which will hopefully get the RI back up and running (maybe in 15-20 mins? - honestly not sure how long it takes). |
I think it takes more than 40 minutes for RI to spin up usually. |
I forgot, I had: https://web-rdikukigkjapf0z74ocsofi8izmc2gmo.demo.cms.va.gov/boston-vet-center/ because of the RI being odd |
LGTM! |
Looks good to me! |
DO NOT MERGE UNTIL NOTIFICATIONS MADE TO VET CENTER EDITORS
Summary
Related issue(s)
Testing done
Screenshots
Vet Center Page with mission explainer (Boston Vet Center) - Desktop (above 768px)
Vet Center Page with mission explainer (Boston Vet Center) - below 768px
Vet Center Page missing mission explainer in tugboat (looks exactly the same as current Vet Center) - fixed in prod and staging so this does not occur but added to show logic exists if some VC removes it somehow
What areas of the site does it impact?
Affects Vet Center pages
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Check https://web-rdikukigkjapf0z74ocsofi8izmc2gmo.demo.cms.va.gov/boston-vet-center/
If this is reset before you view, re-release content on that tugboat with 2307 as the PR for content-build.
Check page/component at 767px or lower and 769px or greater. At 767px or lower, should have a margin of 32px below mission explainer and above va-on-this-page component (with a border). At 769px or greater, should not have this margin, because the lack of border makes it appear far enough away from the va-on-this-page content