Skip to content

Commit

Permalink
Revert unnecessary updates for data-templates etc
Browse files Browse the repository at this point in the history
  • Loading branch information
randimays committed Nov 14, 2024
1 parent 83d4e27 commit db7b65e
Show file tree
Hide file tree
Showing 14 changed files with 33 additions and 16 deletions.
14 changes: 7 additions & 7 deletions src/data/queries/tests/__snapshots__/newsStory.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"All hospital environments can be intense and demanding and come with general and specific challenges. But having co-workers whom one can count on makes my job at VA an invaluable opportunity."
</p>
n
<p>Decker
said
Expand Down Expand Up @@ -149,7 +149,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"The 'aha moment' when it all comes together is very gratifying."
</p>
n
<p>Even so, Decker says preventing illness in the first place is even more gratifying.</p>
Expand All @@ -160,7 +160,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"Preventing 10 patients from getting sick is even better, and that's what we strive to do in Infection Prevention."
</p>
n
<p>Rahman said he's been fascinated since childhood with how the human body works.</p>
Expand All @@ -171,7 +171,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"Cardiology is not just a career choice, but a calling, and I think it found me."
</p>
n
<p>Both doctors said the best part of working at VA is listening to Veterans' stories.</p>
Expand All @@ -182,7 +182,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"I've met some truly great people working at VA."
</p>
n
<p>Rahman said Veterans' stories make every day at work interesting.</p>
Expand All @@ -193,7 +193,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"It's never a dull day at work."
</p>
n
<p>Decker and Rahman were formally recognized as Outstanding Physicians of the Year on April 26 during the medical staff's quarterly meeting at University Drive.</p>",
"breadcrumbs": [
{
Expand Down Expand Up @@ -362,7 +362,7 @@ exports[`node--news_story formatData outputs formatted data 1`] = `
"width": 456,
},
"introText": "When a hospital has a host of great doctors, honoring just two every year is challenging. ",
"lastUpdated": "2020-03-24T20:10:28+00:00",
"lastUpdated": "2019-05-14T15:35:12+00:00",
"listing": "/pittsburgh-health-care/stories",
"metatags": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`Person profile returns formatted data outputs formatted data 1`] = `
"id": "fe42bc63-0933-40bb-978a-ef951fa75684",
"introText": null,
"lastName": "Doyle",
"lastUpdated": "2019-08-27T17:49:03+00:00",
"lastUpdated": "2019-08-26T22:03:30+00:00",
"media": {
"alt": "Patrick J. Doyle",
"height": 129,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ exports[`node--press_release formatData output formatted data 1`] = `
"fullText": "<p>We invite you to come and read our 2019 Annual Report. </p>",
"id": "6153ed5b-85c2-4ead-9893-3d656ad5d758",
"introText": "We invite you to come and read our 2019 Annual Report. ",
"lastUpdated": "2021-04-12T14:27:39+00:00",
"lastUpdated": "2021-04-12T14:25:27+00:00",
"listing": "/wilmington-health-care/news-releases",
"metatags": [
{
Expand Down
1 change: 1 addition & 0 deletions src/templates/components/collapsiblePanel/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export const CollapsiblePanel = ({
return (
<div
id={id}
data-template="paragraphs/collapsible_panel"
data-paragraph-type="paragraph--collapsible_panel"
data-entity-id={entityId}
data-multiselectable={multiSelect}
Expand Down
3 changes: 2 additions & 1 deletion src/templates/components/healthServices/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ function HealthServices({ services, typeOfCare }: HealthServicesProps) {
<>
<h2
id={typeOfCare}
className="vads-u-margin-top--0 vads-u-font-size--lg mobile-lg:vads-u-font-size--xl vads-u-margin-bottom--2"
className="vads-u-margin-top--0 vads-u-font-size--lg
mobile-lg:vads-u-font-size--xl vads-u-margin-bottom--2"
>
{heading}
</h2>
Expand Down
2 changes: 1 addition & 1 deletion src/templates/components/hours/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const Hours = ({ allHours, headerType }: HoursProps) => {
}

return (
<div className="vads-u-margin-bottom--0">
<div className="vads-u-margin-bottom--0" data-template="hours">
<div className="clinicalhours">
{renderHeader()}
<div className="vads-u-display--flex vads-u-flex-direction--column mobile-lg:vads-u-flex-direction--row vads-u-margin-bottom--0">
Expand Down
6 changes: 5 additions & 1 deletion src/templates/components/numberCallout/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ export function NumberCallout({
description,
}: FormattedNumberCallout) {
return (
<div data-entity-id={entityId} className="card information">
<div
data-template="paragraphs/number_callout"
data-entity-id={entityId}
className="card information"
>
<span className="number">{numberPhrase}</span>
<span className="description">{description}</span>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/templates/components/processList/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { numToWord } from '@/lib/utils/helpers'
export function ProcessList({ steps, entityId }: FormattedProcessList) {
if (!steps) return
return (
<div data-entity-id={entityId} className="process schemaform-process">
<div
data-template="paragraphs/process"
data-entity-id={entityId}
className="process schemaform-process"
>
<ol>
{steps &&
steps.map((step, index) => (
Expand Down
1 change: 1 addition & 0 deletions src/templates/components/qaCollapsiblePanel/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const QaCollapsiblePanel = ({ questions }) => {
>
<div
id={questionObject.id}
data-template="paragraphs/q_a.collapsible_panel__qa"
data-entity-id={questionObject.id}
data-analytics-faq-section={questionObject.header}
data-analytics-faq-text={questionObject.question}
Expand Down
2 changes: 1 addition & 1 deletion src/templates/components/qaParagraph/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function QaParagraph({
}: FormattedQaParagraph) {
const DynamicHeader = setHeaderh3 ? 'h3' : 'h2'
return (
<div>
<div data-template="paragraphs/q_a">
<div>
<div className="vads-u-display--flex">
<DynamicHeader>{question}</DynamicHeader>
Expand Down
1 change: 1 addition & 0 deletions src/templates/components/reactWidget/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const DefaultWidget = ({
}) => {
return (
<div
data-template="paragraphs/react_widget"
data-entity-id={entityId}
data-widget-type={widgetType}
data-widget-timeout={timeout}
Expand Down
6 changes: 5 additions & 1 deletion src/templates/components/wysiwyg/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ export function Wysiwyg({
if (!isValidData(html)) return

return (
<div data-entity-id={entityId} data-paragraph-type="paragraph--wysiwyg">
<div
data-entity-id={entityId}
data-template="paragraphs/wysiwyg"
data-paragraph-type="paragraph--wysiwyg"
>
<WysiwygField html={html} />
</div>
)
Expand Down
2 changes: 1 addition & 1 deletion src/templates/layouts/questionAnswer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const QuestionAnswer = ({
}
}
return (
<div id="content" className="interior">
<div id="content" className="interior" data-template="node-q_a">
<div className="va-l-detail-page">
<div className="usa-grid usa-grid-full">
<div className="usa-width-three-fourths">
Expand Down
1 change: 1 addition & 0 deletions src/templates/layouts/resourcesSupport/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const ResourcesSupport = ({
<div
id="content"
className="interior"
data-template="node-support_resources_detail_page"
data-resource-type="node--support_resources_detail_page"
>
<main className="va-l-detail-page">
Expand Down

0 comments on commit db7b65e

Please sign in to comment.