Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15061 Story layout fixes #235

Merged
merged 3 commits into from
Nov 7, 2023
Merged

15061 Story layout fixes #235

merged 3 commits into from
Nov 7, 2023

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented Nov 7, 2023

Description

Relates to #15061. (or closes?)

  • Adds feedback button styling
  • Puts content footer below article for correct padding
  • Adds conditional class for padding below newstory images

Testing done

Local visual testing

Screenshots

Screen Shot 2023-11-07 at 10 23 08 AM Screen Shot 2023-11-07 at 10 23 21 AM

QA steps

  • Navigate to a story listing page (/butler-health-care/stories/)
    • Verify layout matches prod
  • Navigate to story page
    • Verify layout matches prod

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 7, 2023 15:26 Destroyed
@@ -11,6 +11,17 @@ body {
box-sizing: border-box;
}

.feedback-button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can actually nix this, I previously got feedback from the design system team that this was a one-off style that shouldn't have been implemented in CB in the first place.

department-of-veterans-affairs/va.gov-cms#15511 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, removed. Thanks!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 7, 2023 16:29 Destroyed
@tjheffner tjheffner merged commit c3cac0d into main Nov 7, 2023
3 checks passed
@tjheffner tjheffner deleted the 15061-stories-layout branch November 7, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants