Vacms 15949 cleanup

[ryguyk]

Description

Closes department-of-veterans-affairs/va.gov-cms#15949

This is a refactor. No functionality is changed.

Our TypeScript types needed some cleanup and normalization. This PR goes a long way toward accomplishing that. The cleanup uncovered a few silent issues with some types that are also resolved by this PR, but the bulk of the work boils down to implementing this model:

• TypeScript types for data can be thought of as before and after formatting. Types for before formatting are in types/dataTypes/drupal. Types for after formatting are in types/dataTypes/formatted.
• Pre-formatted types are types specific to Drupal. If we added another data source or replaced Drupal altogether, types for the new data source could augment or replace these types. Those new types would get formatted into the same formatted types.
• In this way, our application logic is decoupled from the specifics of the data source. Our business logic can be written to use the normalized/formatted data properties.

This model was already largely implemented, but it wasn't clean or explicit. Additionally, there were a number of places (and still might be a few) where "formatted" data types contained properties that were pre-formatted types. This sort of mixing is ripe for confusion at least, and, more than likely, bugs.

Another thing that is noteworthy is that this PR removes index.d.ts. That file held the bulk of the formatted type definitions, but naming it with the .d.ts extension was not entirely correct. That extension is generally reserved for defining types for external libraries. Using it here led to some silent type mismatches. The result of the move, as mentioned above, uncovered these previously silent type problems, so this PR addresses those as well.

Testing done/QA steps

• Ensure existing unit tests still pass
• Ensure build still succeeds.
• A lot of manual QA. This changes a ton of files, and it needs to be tested accordingly.

[tjheffner]

thank you for tackling this cleanup, it reads much better! and will be much easier to extend in the future, thanks to the now clearly explicit drupal / formatted type split